Page MenuHome

Restrict temp/Maximized/Fullscreen window editing
Needs ReviewPublic

Authored by Jake (Welp) on Dec 3 2021, 2:36 AM.

Details

Summary

Restrict temp/Maximized/Fullscreen window editing in a few more places, and disable the ActionZone corners on Maximized areas since they don't do anything.

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 22311
Build 22311: arc lint + arc unit

Event Timeline

Jake (Welp) requested review of this revision.Dec 3 2021, 2:36 AM
Jake (Welp) created this revision.
Jake (Welp) updated this revision to Diff 45616.Dec 3 2021, 7:59 PM
  • Remove obsolete check for active op on filebrowser
Julian Eisel (Severin) requested changes to this revision.May 23 2022, 6:27 PM

Small request, but generally this is fine.

source/blender/editors/interface/interface_templates.c
109

Better to put this in a function:

bool ED_screen_editable(const bScreen *screen)
{
  reteurn (screen->state == SCREENNORMAL) && !screen->temp;
}

Avoids duplicating this check but also documents the intended meaning of the check via the function name.

This revision now requires changes to proceed.May 23 2022, 6:27 PM
source/blender/editors/screen/screen_ops.c
5474

Unused.

source/blender/makesrna/intern/rna_screen.c
128

r_info also needs to be marked as UNUSED().

Requested Changes
Jake (Welp) marked 3 inline comments as done.May 29 2022, 6:12 PM