Fix T55670: Witcher 3 FBX import bones/vertex weights not imported
AbandonedPublic
Actions

Authored by Demeter Dzadik (Mets) on Dec 3 2021, 3:16 PM.

Details

Reviewers

Maniphest Tasks

T55670: Witcher 3 FBX import armature/bones/vertex weights not imported

Summary

Adds 'Root' as a potential name for fbx "helper nodes", to support FBX files output by Witcher 3 Model Converter.
This is a hack on top of a hack, and I know nobody wants to deal with the FBX importer, but I think it's quite harmless, and I need it to develop and distribute tools to manage Witcher 3 files with Blender, so I hope I can commit it.

If it turns out to break anything, it can always be reverted! :)

Diff Detail

Repository

rBA Blender Add-ons

Branch

master

Build Status

Buildable 19180
Build 19180: arc lint + arc unit

Event Timeline

Demeter Dzadik (Mets) requested review of this revision.Dec 3 2021, 3:16 PM

Demeter Dzadik (Mets) created this revision.

Harbormaster completed remote builds in B19180: Diff 45609.Dec 3 2021, 3:16 PM

Demeter Dzadik (Mets) added a reviewer: Bastien Montagne (mont29).Dec 3 2021, 3:16 PM

Demeter Dzadik (Mets) added a task: T55670: Witcher 3 FBX import armature/bones/vertex weights not imported.Dec 3 2021, 3:29 PM

Talked with @Demeter Dzadik (Mets) , this is pending some more testing from his side to have a reasonable assurance it does not break existing behavior...

If tests pass, think we can accept that.

This revision now requires changes to proceed.Dec 3 2021, 3:37 PM

I asked around and I looked around:
Maya:

tereza_skel_from_maya.fbx324 KBDownload

Max:

simple_character_from_max.FBX857 KBDownload

Mixamo:

Taunt_mixamo.fbx2 MBDownload

UE4:

akeytsu_from_ue4.fbx1 MBDownload

Some Unity asset extractor:

chikasheadonastick_from_unity_asset_extractor.fbx390 KBDownload

All of those files have armatures in them, and in my tests, they import identically with or without the patch.

And then, everything changed, when Unity attacked.

BinaryThing_from_unity.fbx49 KBDownload

For some god-forsaken reason, this file actually behaves differently because of this patch. So... nevermind! :D I tried!

Revision Contents
Changeset List

Path

Size

io_scene_fbx/

import_fbx.py

2 lines

Diff 45609

View Options

io_scene_fbx/import_fbx.py

Fix T55670: Witcher 3 FBX import bones/vertex weights not importedAbandonedPublicActions