Differential D13464

Fix linking against libXxf86vm
AbandonedPublic
Actions

Authored by Sam James (thesamesam) on Dec 4 2021, 1:51 AM.

Tags

Subscribers

Ankit Meel (ankitm)

Details

Reviewers

Sebastian Parborg (zeddb)

Group Reviewers

Platforms, Builds, Tests & Devices

Summary

This change fixes linking against libXxf86vm. The issue was a typo which resulted in inconsistency between where we find libXxf86vm and where we try to use the results of the search (its include path and where the library resides).

/usr/lib/gcc/x86_64-pc-linux-gnu/11.2.1/../../../../x86_64-pc-linux-gnu/bin/ld: lib/libbf_intern_ghost.a(GHOST_DisplayManagerX11.cpp.o): undefined reference to symbol 'XF86VidModeGetAllModeLines'
/usr/lib/gcc/x86_64-pc-linux-gnu/11.2.1/../../../../x86_64-pc-linux-gnu/bin/ld: /usr/lib64/libXxf86vm.so: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

Diff Detail

Repository: rB Blender

Event Timeline

Sam James (thesamesam) requested review of this revision.Dec 4 2021, 1:51 AM

Sam James (thesamesam) created this revision.

Sam James (thesamesam) retitled this revision from Fix link to Fix linking against libXxf86vm.Dec 4 2021, 1:55 AM

Sam James (thesamesam) added a project: Platforms, Builds, Tests & Devices.Dec 4 2021, 5:53 AM

Sam James (thesamesam) added a reviewer: Platforms, Builds, Tests & Devices.

duplicate of D12911: cmake: fix linking with WITH_X11_XF86VMODE and bfd

Ankit Meel (ankitm) mentioned this in D12911: cmake: fix linking with WITH_X11_XF86VMODE and bfd.Dec 4 2021, 7:03 AM

I'll discuss this with Sybren on Monday :)

Will will merge the other (older) patch that does the same thing.
Thanks for bringing this to our attention (ones again)! :)

Revision Contents
Changeset List

Path

Size

intern/

ghost/

4 lines

Diff 45623

intern/ghost/CMakeLists.txt

Loading...