Differential D13468

Fix Shadow Terminator Geometry Offset artifacts for translucent shader (Cycles)
ClosedPublic
Actions

Authored by Mikhail Matrosov (ktdfly) on Dec 4 2021, 11:13 PM.

Tags

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)

Maniphest Tasks

T93418: Shadow Terminator Geometry Offset causes artifacts for translucent shader (Cycles)

Commits

rB4c8740a45217: Fix T93418: Cycles shadow terminator Geometry Offset artifacts with translucency
rC994fe98ab523: Fix T93418: Cycles shadow terminator Geometry Offset artifacts with translucency
rBa92805bf24f5: Fix T93418: Cycles shadow terminator Geometry Offset artifacts with translucency

Summary

Fixes T93418: Shadow Terminator Geometry Offset causes artifacts for translucent shader (Cycles) by setting a correct offset amount for backfaces.

Diff Detail

Repository: rB Blender

Event Timeline

Mikhail Matrosov (ktdfly) requested review of this revision.Dec 4 2021, 11:13 PM

Mikhail Matrosov (ktdfly) created this revision.

Mikhail Matrosov (ktdfly) created this object with edit policy "Administrators".

Alaska (Alaska) added a task: T93418: Shadow Terminator Geometry Offset causes artifacts for translucent shader (Cycles).Dec 4 2021, 11:35 PM

Thanks!

This revision is now accepted and ready to land.Dec 7 2021, 6:47 PM

Brecht Van Lommel (brecht) added inline comments.Dec 7 2021, 6:48 PM

intern/cycles/kernel/light/sample.h
203	To follow code convention, add {} brackets.

Closed by commit rBa92805bf24f5: Fix T93418: Cycles shadow terminator Geometry Offset artifacts with translucency (authored by Mikhail Matrosov (ktdfly), committed by Brecht Van Lommel (brecht)). · Explain WhyDec 7 2021, 7:02 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rBa92805bf24f5: Fix T93418: Cycles shadow terminator Geometry Offset artifacts with translucency.

Brecht Van Lommel (brecht) added a commit: rC994fe98ab523: Fix T93418: Cycles shadow terminator Geometry Offset artifacts with translucency.Jan 27 2022, 11:37 PM

Philipp Oeser (lichtwerk) added a commit: rB4c8740a45217: Fix T93418: Cycles shadow terminator Geometry Offset artifacts with translucency.Mar 28 2022, 1:34 PM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

kernel/

light/

1 line

Diff 45635

intern/cycles/kernel/light/sample.h

Loading...