Page MenuHome
Differential D13504

Geometry Nodes: Mesh Island Field Input Node
ClosedPublic
Actions

Authored by Johnny Matthews (guitargeek) on Dec 7 2021, 7:37 PM.
Tags
Subscribers
None
Tokens
"Love" token, awarded by mcurt09."Love" token, awarded by lopoIsaac."Love" token, awarded by HEYPictures."Love" token, awarded by mswf.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Jacques Lucke (JacquesLucke)
Commits
rB069d63561a4c: Geometry Nodes: Mesh Island Node
Summary

This node is a field input that outputs a separate index for each mesh island. The indices are based on the order of the lowest-numbered vertex in each island.

For example: if the islands were defined as the following groups of vertex indices:

0,1,2,4,56,73

The indices of the 3 islands would be:

021

Example File by @Hans Goudey (HooglyBoogly)

Mesh Island Test.blend866 KBDownload

Diff Detail

Repository
rB Blender
Branch
mesh_island (branched from master)
Build Status
Buildable 19281
Build 19281: arc lint + arc unit

Event Timeline

Johnny Matthews (guitargeek) requested review of this revision.Dec 7 2021, 7:37 PM
Johnny Matthews (guitargeek) created this revision.
Harbormaster completed remote builds in B19281: Diff 45785.Dec 7 2021, 7:37 PM
Johnny Matthews (guitargeek) edited the summary of this revision. (Show Details)Dec 7 2021, 9:09 PM
Johnny Matthews (guitargeek) added a project: Geometry Nodes.
Johnny Matthews (guitargeek) edited the summary of this revision. (Show Details)Dec 7 2021, 9:11 PM
Johnny Matthews (guitargeek) added a reviewer: Jacques Lucke (JacquesLucke).
Hans Goudey (HooglyBoogly) requested changes to this revision.EditedDec 7 2021, 10:31 PM

Great patch! Quite simple too!

It would be nice to have a test file and a screenshot in the patch description. (I'd like to start making that the responsibility of the patch author). That can later become a regression test. Here's a pretty stupid test file:

Mesh Island Test.blend866 KBDownload

/home/hans/Blender-Git/blender/source/blender/nodes/geometry/nodes/node_geo_input_mesh_island.cc: In member function ‘virtual blender::fn::GVArray blender::nodes::node_geo_input_mesh_island_cc::IslandFieldInput::get_varray_for_context(const GeometryComponent&, AttributeDomain, blender::IndexMask) const’:
/home/hans/Blender-Git/blender/source/blender/nodes/geometry/nodes/node_geo_input_mesh_island.cc:74:3: error: control reaches end of non-void function [-Werror=return-type]
source/blender/nodes/geometry/nodes/node_geo_input_mesh_island.cc
16

Newline here

36

"Field" is redundant here IMO, I think "Index" is more helpful.

45

We can avoid indenting the rest of the function:

if (component.type() != GEO_COMPONENT_TYPE_MESH) {
  return {};
}
const MeshComponent &mesh_component = static_cast<const MeshComponent &>(component);
57–69

I think I found a somewhat simpler way to write the ordering:

Array<int> output(mesh->totvert);
VectorSet<int> ordered_roots;
for (const int i : IndexRange(mesh->totvert)) {
  const int64_t root = islands.find_root(i);
  output[i] = ordered_roots.index_of_or_add(root);
}
This revision now requires changes to proceed.Dec 7 2021, 10:31 PM
Johnny Matthews (guitargeek) edited the summary of this revision. (Show Details)Dec 7 2021, 11:35 PM
Johnny Matthews (guitargeek) updated this revision to Diff 45791.Dec 7 2021, 11:37 PM
Johnny Matthews (guitargeek) marked 4 inline comments as done.
  • Merge branch 'master' into mesh_island
  • Simplify the island numbering with a VectorSet
Harbormaster completed remote builds in B19285: Diff 45791.Dec 7 2021, 11:37 PM
Steff Kempink (mswf) awarded a token.Dec 8 2021, 11:26 AM
HEYPictures (HEYPictures) awarded a token.Dec 8 2021, 12:18 PM
Lopo Isaac (lopoIsaac) awarded a token.Dec 8 2021, 2:39 PM
Hans Goudey (HooglyBoogly) accepted this revision.Dec 8 2021, 3:37 PM
Hans Goudey (HooglyBoogly) added 1 blocking reviewer(s): Jacques Lucke (JacquesLucke).
Jacques Lucke (JacquesLucke) accepted this revision.Dec 8 2021, 4:12 PM
Jacques Lucke (JacquesLucke) added inline comments.
release/scripts/startup/nodeitems_builtins.py
157

Trailing whitespace.

source/blender/nodes/geometry/nodes/node_geo_input_mesh_island.cc
32

Add a description about the ordering.

This revision is now accepted and ready to land.Dec 8 2021, 4:12 PM
Closed by commit rB069d63561a4c: Geometry Nodes: Mesh Island Node (authored by Johnny Matthews (guitargeek)). · Explain WhyDec 8 2021, 5:15 PM
This revision was automatically updated to reflect the committed changes.
Johnny Matthews (guitargeek) marked an inline comment as done.
Johnny Matthews (guitargeek) added a commit: rB069d63561a4c: Geometry Nodes: Mesh Island Node.
Matt Curtis (mcurt09) awarded a token.Dec 14 2021, 12:17 AM

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
1 line
source/
blender/
blenkernel/
1 line
intern/
1 line
nodes/
1 line
1 line
geometry/
1 line
nodes/
105 lines

Diff 45785

View Options

release/scripts/startup/nodeitems_builtins.py

Loading...
View Options

source/blender/blenkernel/BKE_node.h

Loading...
View Options

source/blender/blenkernel/intern/node.cc

Loading...
View Options

source/blender/nodes/NOD_geometry.h

Loading...
View Options

source/blender/nodes/NOD_static_types.h

Loading...
View Options

source/blender/nodes/geometry/CMakeLists.txt

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_input_mesh_island.cc

Loading...