Pretty basic but also pretty solid working hack to fix the bad cursor
offset behavior in Side by Side/Top Bottom modes.
Idea is basically to offset the mouse coordinates before sending.
Differential D1350
Multi-View: Fix Side by Side/Top Bottom mode bad cursor behaviour Authored by Julian Eisel (Severin) on Jun 12 2015, 12:11 PM. Tags Subscribers None
Details
Pretty basic but also pretty solid working hack to fix the bad cursor Idea is basically to offset the mouse coordinates before sending.
Diff Detail
Event TimelineComment Actions Noted other events e.g. from trackpads change event->x/y as well, but can't check atm, will do that later. Comment Actions A few issues:
Comment Actions Re: cursor is drawn for the top (or left) eye only: However, I'm afraid that fixing the blinking cursor isn't that easy. Googled a bit but seems like cursor drawing is low level OS code which we can't influence (except of disabling it completely/changing appearance). Maybe this is just a limitation we have to live with :| (although we could do crazy things like using a custom cursor set that we can draw a second time, but don't think that's a good solution either) Re: Camera navigation no longer working PS: Not easy to describe these things, hope you get what I mean :D
Comment Actions The 'software' cursor would be the correct way to go indeed. But it may be too much work, and maybe your patch can provide a bad provisory solution. Just to illustrate the issue with your approach: Comment Actions Well even if we had a software cursor, the interface handling would still be done using window space mouse coordinates so we still had the same offset we have now if I'm not missing something. If we had a complete software cursor pipeline where we were able to offset the cursor drawing position, we'd have jumping cursors while entering/exiting the Blender window, entering/exiting multiview, etc - changing the cursor position without user input is really bad UX wise and should definitely be avoided. Instead, just a second cursor in the other window half should appear. All proper fixes I can think of would consist out of two parts:
Whereby the second part is tackled with this patch. I agree that this isn't the solution for all problems, but think it is the first part of it. Comment Actions @Dalai Felinto (dfelinto), what's your current opinion on this, still think it's okay as a fix. Comment Actions @Julian Eisel (Severin) alright, but how about having a patch with the drawing part too? Is this something you plan to tackle eventually? Comment Actions Changes in event system are always a bit risky, even if this patch shouldn't touch non-multiview mode. Will commit after release, just to be safe. Comment Actions Committed rB80444effc62ac9, as it's also going to affect the ongoing HMD support implementation. | ||||||||||||||