Add a boolean field input to Attribute Statistics to determine if the data at that index should be computed in the output.
Demo File:
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
| source/blender/nodes/geometry/nodes/node_geo_attribute_statistic.cc | ||
|---|---|---|
| 35 | Selection inputs should go below the geometry input. | |
| 163 | I don't think there's any need to initialize the values. | |
| 168 | No need for a temporary array here if it's just going to be copied into the data vector after. | |
| 176 | I think these could be simplified by slicing data beforehand, then iterating over selection.index_range() rather than keeping track of a "position" | |
| 185 | I'm not sure how resizing this *after* adding the data to it works, I think data could just be an array instead, since the size is known beforehand. | |
| 242 | Don't reuse a variable and give it a different meaning. | |
| source/blender/nodes/geometry/nodes/node_geo_attribute_statistic.cc | ||
|---|---|---|
| 185 | Maybe I'm misunderstanding something then. Here was my logic:
| |
| source/blender/nodes/geometry/nodes/node_geo_attribute_statistic.cc | ||
|---|---|---|
| 185 | That works, but there's no need to evaluate into an array directly, you can just use const VArray<float3> &component_data = data_evaluator.get_evaluated<float3>() And you resized the vector to total_size earlier in the function, there shouldn't be any extra room at the end. (You never call append) | |
Comment Actions
Closer!
| source/blender/nodes/geometry/nodes/node_geo_attribute_statistic.cc | ||
|---|---|---|
| 158–167 | Maximum size is never used, so this calculation could be completely removed. | |
| 171 | Moving from the selection field won't work if there is more than one component | |
| 176 | I still think this would be an improvement. | |
| 177 | I doesn't seem correct to subtract one here, what's the reasoning for that? | |
| 263 | It looks simpler to just skip this variable and call data.size() below. | |
| source/blender/nodes/geometry/nodes/node_geo_attribute_statistic.cc | ||
|---|---|---|
| 177 | just a severe case of copy-and-paste-itis | |
Comment Actions
Looks good to me now :)
| source/blender/nodes/geometry/nodes/node_geo_attribute_statistic.cc | ||
|---|---|---|
| 176 | const (same with the other) | |