Details

Reviewers

Maniphest Tasks

T71899: Sculpt move tool is applied when clicking within negative space of UI, regardless of active sculpt tool
T91579: Click and drag on the right panel tabs will call active tool (Tweak, Box Select etc)
T91538: Pose library panel doesn't play well with left click keymap for viewport rotation
T94016: Pose Library: Clicking through the interface
T92364: UX: Prevent click-through panels and used header area

Commits

rB87c13ac68c47: UX: Prevent click-through panels and used header area

Summary

Does two main changes:

Handle regions in the order as visible on screen. Practically this just means handling overlapping regions before non-overlapping ones.
Don't handle any other regions after having found one containing the mouse pointer.

Like T92364 suggests, this patch changes the clickable area from this:

To almost exactly this:

The Move Orientation: labels on the left of the 3D View tool header can still be clicked through in this patch, otherwise it seems to match.

Fixes T94016, T91538, T91579, T71899.

Diff Detail

Repository

rB Blender

Branch

temp-click-through-fix (branched from master)

Build Status

Buildable 20168
Build 20168: arc lint + arc unit

Event Timeline

Julian Eisel (Severin) requested review of this revision.Dec 10 2021, 6:47 PM

Julian Eisel (Severin) created this revision.

Harbormaster completed remote builds in B19355: Diff 45922.Dec 10 2021, 6:47 PM

Fix missing HANDLED return value print in debug prints

Harbormaster completed remote builds in B19356: Diff 45923.Dec 10 2021, 7:02 PM

Julian Eisel (Severin) added a project: User Interface.Dec 10 2021, 7:03 PM

Julian Eisel (Severin) added inline comments.

source/blender/windowmanager/intern/wm_event_system.c
636–647	This sanity check can(/should) be a separate patch. It was used in an earlier version but isn't really needed anymore. I'd still like to add it.

Julian Eisel (Severin) edited the summary of this revision. (Show Details)Dec 10 2021, 7:05 PM

Julian Eisel (Severin) added a task: T92364: UX: Prevent click-through panels and used header area.

Julian Eisel (Severin) edited the summary of this revision. (Show Details)Dec 10 2021, 7:11 PM

Julian Eisel (Severin) edited the summary of this revision. (Show Details)

Julian Eisel (Severin) mentioned this in T92364: UX: Prevent click-through panels and used header area.Dec 10 2021, 7:13 PM

Hans Goudey (HooglyBoogly) added a subscriber: Hans Goudey (HooglyBoogly).Dec 10 2021, 7:20 PM

Hans Goudey (HooglyBoogly) added inline comments.

source/blender/windowmanager/intern/wm_event_system.c
641	Just passing through and curious-- is there any particular reason to use `BLI_INLINE` here? I assumed we left that complexity to when it provides a real benefit.

Julian Eisel (Severin) added inline comments.Dec 10 2021, 7:31 PM

source/blender/windowmanager/intern/wm_event_system.c
641	Since this is really a debug-only check, the extra function call would be a waste of CPU cycles in release builds. I'd be disappointed if compilers didn't already optimize this out, but yeaaah :) So `BLI_INLINE` is just to enforce that, but no strong feelings about it, we can probably trust compilers to figure this out.

William Reynish (billreynish) awarded a token.Dec 10 2021, 11:49 PM

Julian Eisel (Severin) mentioned this in T91538: Pose library panel doesn't play well with left click keymap for viewport rotation.Dec 11 2021, 2:27 AM

Julian Eisel (Severin) edited the summary of this revision. (Show Details)Dec 13 2021, 6:16 PM

Julian Eisel (Severin) added tasks: T94016: Pose Library: Clicking through the interface, T91538: Pose library panel doesn't play well with left click keymap for viewport rotation.

Pablo Vazquez (pablovazquez) awarded a token.Jan 3 2022, 9:58 PM

Add missing null-check
Fix possible parallel execution of window and region handlers

Harbormaster completed remote builds in B20037: Diff 47140.Jan 17 2022, 3:05 PM

Merge branch 'master'

Harbormaster completed remote builds in B20168: Diff 47443.Jan 25 2022, 5:13 PM

This is great! From my tests in several layouts it seems to work as expected. There might be corner cases though so better get it in before/early bcon3.

Here's a quick video, left side is master, right is this patch:

Two more reports fixed by this patch T91579, T71899.

Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).Jan 26 2022, 5:17 PM

Julian Eisel (Severin) edited the summary of this revision. (Show Details)Jan 27 2022, 11:29 AM

Julian Eisel (Severin) added tasks: T91579: Click and drag on the right panel tabs will call active tool (Tweak, Box Select etc), T71899: Sculpt move tool is applied when clicking within negative space of UI, regardless of active sculpt tool.

Vyacheslav (hitrpr) awarded a token.Jan 27 2022, 11:59 AM

Raimund Klink (Raimund58) added a subscriber: Raimund Klink (Raimund58).Jan 27 2022, 12:51 PM

This seems fine, in some cases the margins seem a bit large (lower part of the toolbar for e.g.) but this can be tweaked separately.

Ran into some issues with asserting when opening new files and pressing keys fast, noted inline.

These should be straightforward to solve, so accepting the patch.

source/blender/windowmanager/intern/wm_event_system.c
643	This is asserting is you press multiple keys at once, it's difficult to redo, pressing `sdf` and `xcv` keys in edit-mesh can sometimes redo it. This can be triggered using the following test: `../lib/tests/ui_simulate/run.py --blender='./blender.bin -d --log "ed.undo.*" --log-level 1 --log-show-basename' --tests "test_undo.view3d_mesh_edit_separate"`
3135	This is crashing on making a new file, checking if `CTX_wm_window(C)` isn't NULL resolves.