Page MenuHome

Geometry Nodes: Support instances in the delete geometry node
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Dec 14 2021, 5:05 AM.

Details

Summary

Ever since the instance domain was added, this was exposed, it just
didn't do anything. This patch implements the instances domain in the
delete and separate geometry nodes, where it acts on the top-level
instances.

We act on a mutable instances input, with the idea that eventually
copy on write attribute layers will make this less expensive. It also
allows us to keep the instance references in place and to do less
work in some situations.

Ref T93554

Diff Detail

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Dec 14 2021, 5:05 AM
Hans Goudey (HooglyBoogly) created this revision.
Jacques Lucke (JacquesLucke) added inline comments.
source/blender/nodes/geometry/nodes/node_geo_delete_geometry.cc
558

Note that this wouldn't work when copy_data_based_on_mask is multi-threaded. Not sure it's a good idea to depend on that.

This revision is now accepted and ready to land.Dec 14 2021, 12:48 PM
Hans Goudey (HooglyBoogly) planned changes to this revision.Dec 14 2021, 4:40 PM

Shoot, you're right. I'd like to avoid depending on that too, I'll rework this change.

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)
  • Switch to a different method
  • Cleanup
This revision is now accepted and ready to land.Dec 28 2021, 10:05 PM