Page MenuHome
Differential D13566

Geometry Nodes: Add 'Keep Shape' Input to Set Spline Cyclic
Needs ReviewPublic
Actions

Authored by Johnny Matthews (guitargeek) on Dec 14 2021, 6:56 AM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Summary

Initial Support for Keep Shape, a boolean field evaluated on the spline domain which instead of making a spline cyclic, creates a final point on each referenced spline that is the same as the first point on the same spline

NURBS are not supported yet as cyclic is more than just another point added to the spline. If a NURBS spline is set to keep shape, it will simply be left in cyclic mode and a node warning is displayed.

T93821

Remaining Issues:

  • correcting the tilt attribute when the spline is not cyclic anymore and the spline is in minimum-twist mode. Also see calculate_normals_minimum.

Is this the desired logic flow for this node?

Diff Detail

Repository
rB Blender
Branch
keepshape (branched from master)
Build Status
Buildable 20223
Build 20223: arc lint + arc unit

Event Timeline

Johnny Matthews (guitargeek) requested review of this revision.Dec 14 2021, 6:56 AM
Johnny Matthews (guitargeek) created this revision.
Harbormaster completed remote builds in B19409: Diff 46007.Dec 14 2021, 6:56 AM
Jacques Lucke (JacquesLucke) added a subscriber: Jacques Lucke (JacquesLucke).Dec 14 2021, 1:16 PM

I mentioned it on the task already, but will mention it here again. I think one of the more tricky issues is correcting the tilt attribute when the spline is not cyclic anymore and the spline is in minimum-twist mode. Also see calculate_normals_minimum.

Johnny Matthews (guitargeek) edited the summary of this revision. (Show Details)Dec 14 2021, 3:32 PM
Johnny Matthews (guitargeek) edited the summary of this revision. (Show Details)Dec 15 2021, 3:02 AM
Johnny Matthews (guitargeek) added a project: Geometry Nodes.
Johnny Matthews (guitargeek) updated this revision to Diff 47707.Jan 28 2022, 11:30 PM
  • Merge branch 'master' into keepshape
  • Copy first point attrs to last point if needed
  • NURBS work, but do not keep shape perfectly. Needs more points?
  • Still need to address minimum twist issue
Harbormaster completed remote builds in B20222: Diff 47707.Jan 28 2022, 11:30 PM
Johnny Matthews (guitargeek) updated this revision to Diff 47708.Jan 28 2022, 11:54 PM
  • Do not apply Keep Shape to Nurbs

If keep shape is true for a nurbs spline and cyclic is on for that spline as well,
simply leave the spline in cyclic mode and set a node warning that Nurbs do not
support keep shape.

Harbormaster completed remote builds in B20223: Diff 47708.Jan 28 2022, 11:54 PM
Johnny Matthews (guitargeek) edited the summary of this revision. (Show Details)Jan 28 2022, 11:56 PM
Johnny Matthews (guitargeek) retitled this revision from Geometry Nodes: Add 'Keep Shape' Input to Set Spline Cyclic - WIP to Geometry Nodes: Add 'Keep Shape' Input to Set Spline Cyclic.Jan 28 2022, 11:58 PM
Jacques Lucke (JacquesLucke) added a comment.Jan 31 2022, 12:06 PM

I'm not entirely sure if we expect the same behavior. Your flow graph seems wrong to me.
I thought the "Keep Shape" option only has an effect when turning a cyclic spline into a non-cyclic one.

Johnny Matthews (guitargeek) updated this revision to Diff 47789.Jan 31 2022, 10:23 PM
  • Merge branch 'master' into keepshape
  • Update Behavior Tree
Harbormaster completed remote builds in B20259: Diff 47789.Jan 31 2022, 10:23 PM
Hans Goudey (HooglyBoogly) mentioned this in T95453: Geometry Nodes 3.2 Targets.Feb 2 2022, 7:59 PM
Janis Grinvalds (grinvaldsjanis) added a subscriber: Janis Grinvalds (grinvaldsjanis).Aug 26 2022, 5:06 PM

Hi! I created a bug report about cyclic bezier which has perpendicular normals at the end.

https://developer.blender.org/T100645

I hope I am pointing to proper taper behavior when the curve is closed and should be continuous.

Iliya Katueshenock (Moder) awarded a token.Aug 26 2022, 6:09 PM
Iliya Katueshenock (Moder) added a subscriber: Iliya Katueshenock (Moder).
Iliya Katueshenock (Moder) added a comment.Aug 26 2022, 6:11 PM
In D13566#428800, @Janis Grinvalds (grinvaldsjanis) wrote:

Hi! I created a bug report about cyclic bezier which has perpendicular normals at the end.

https://developer.blender.org/T100645

I hope I am pointing to proper taper behavior when the curve is closed and should be continuous.

Please stop writing about your problems in the discussion areas of not yet introduced new things. Even if you find a bug, its fix will be developed separately

Janis Grinvalds (grinvaldsjanis) added a comment.Aug 26 2022, 6:29 PM
In D13566#428821, @Iliya Katueshenock (Moder) wrote:

Please stop writing about your problems in the discussion areas of not yet introduced new things. Even if you find a bug, its fix will be developed separately

Stop interrupting me and spoil my enthusiasm in a related area! Your policeman approach is not helpful.

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
geometry/
nodes/
102 lines

Diff 47708

View Options

source/blender/nodes/geometry/nodes/node_geo_set_spline_cyclic.cc

Loading...