Geometry Nodes: Simplify using selection when evaluating field.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Dec 14 2021, 3:01 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Commits

rB8e2c9f2dd311: Geometry Nodes: simplify using selection when evaluating fields

Summary

We often had to use two FieldEvaluator instances to first evaluate the selection and then the remaining fields. Now both can be done with a single FieldEvaluator. This results in less boilerplate code in many cases.
Performance is not affected by this change. In a separate patch we could improve performance by reusing evaluated sub-fields that are used by the selection and the other fields.

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Dec 14 2021, 3:01 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B19422: Diff 46024.Dec 14 2021, 3:01 PM

Tests are running here: https://builder.blender.org/admin/#/builders/18/builds/218

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Dec 14 2021, 3:08 PM

Looks like a good change to me. Apart from the possible future sharing of intermediate values, less boilerplate code is nice.

source/blender/functions/FN_field.hh
342–343	Might be helpful to say something like "Only the elements selected by both this selection and the selection provided in the constructor are calculated."

This revision is now accepted and ready to land.Dec 14 2021, 3:16 PM

Closed by commit rB8e2c9f2dd311: Geometry Nodes: simplify using selection when evaluating fields (authored by Jacques Lucke (JacquesLucke)). · Explain WhyDec 14 2021, 3:40 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB8e2c9f2dd311: Geometry Nodes: simplify using selection when evaluating fields.