Fix T93949: Preview Image Error When No Screen
ClosedPublic
Actions

Authored by Harley Acheson (harley) on Dec 14 2021, 6:00 PM.

Details

Reviewers

Julian Eisel (Severin)

Group Reviewers

User Interface

Maniphest Tasks

T93949: save_as_mainfile will crash if context has no screen

Commits

rBe53f3954a44b: Fix T93949: Preview Image Error When No Screen
rB644eb68524b9: Fix T93949: Preview Image Error When No Screen

Summary

Fix an error if "File Preview Type" is "Auto" and there is no screen.

T93949 Illustrates that it is possible to script the saving of a file when the context has no screen. This results in an error in BKE_screen_find_big_area. This fixes that by checking for screen.

Diff Detail

Repository: rB Blender

Event Timeline

Harley Acheson (harley) requested review of this revision.Dec 14 2021, 6:00 PM

Harley Acheson (harley) created this revision.

Harley Acheson (harley) added a task: T93949: save_as_mainfile will crash if context has no screen.

Julian Eisel (Severin) requested changes to this revision.Dec 14 2021, 6:35 PM

Julian Eisel (Severin) added a subscriber: Julian Eisel (Severin).

Julian Eisel (Severin) added inline comments.

source/blender/windowmanager/intern/wm_files.c
1823	I'd rather have a variable and avoid calling `CTX_wm_screen(C)` twice. Not a big deal, but it does some unnecessary work, possibly including a Python dictionary lookup.

This revision now requires changes to proceed.Dec 14 2021, 6:35 PM