install_deps: Fix OIIO and OSL build with OpenEXR
ClosedPublic
Actions

Authored by Maxime Chambonnet (Maxzor_2_what_the_fuck_blenderid) on Dec 16 2021, 10:27 AM.

Details

Reviewers

Bastien Montagne (mont29)

Commits

rB5adc06d2d898: install_deps: Fix OIIO and OSL build with OpenEXR

Summary

This is maybe more of a bug report than a patch offer :
the correct way to do this would be for someone understanding the history of this OpenEXR
environment variable to properly maintain the script.
But this patch has the merit of hammering the problem away, so maybe it can be helpful.

Other than that, I only had a separate issue with Embree (and python) when building all from source.

BR, Maxime

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 19477
Build 19477: arc lint + arc unit

Event Timeline

Maxime Chambonnet (Maxzor_2_what_the_fuck_blenderid) requested review of this revision.Dec 16 2021, 10:27 AM

Maxime Chambonnet (Maxzor_2_what_the_fuck_blenderid) created this revision.

Harbormaster completed remote builds in B19477: Diff 46110.Dec 16 2021, 10:27 AM

Maxime Chambonnet (Maxzor_2_what_the_fuck_blenderid) retitled this revision from Tiny fix to the valiant script build_files/build_environment/install_deps.sh , updating the environment variables to build OpenImageIO and OpenShadingLanguage. to Tiny fix to the valiant script build_files/build_environment/install_deps.sh ,updating the environment variables to build OpenImageIO and OpenShadingLanguage..Dec 16 2021, 10:35 AM

Maxime Chambonnet (Maxzor_2_what_the_fuck_blenderid) edited the summary of this revision. (Show Details)

Maxime Chambonnet (Maxzor_2_what_the_fuck_blenderid) added reviewers: Bastien Montagne (mont29), Patrick Mours (pmoursnv).

Maxime Chambonnet (Maxzor_2_what_the_fuck_blenderid) added a project: Platforms, Builds, Tests & Devices.

Maxime Chambonnet (Maxzor_2_what_the_fuck_blenderid) added a subscriber: Ray Molenkamp (LazyDodo).

Ray Molenkamp (LazyDodo) removed reviewers: Nicholas Rishel (nicholas_rishel), Patrick Mours (pmoursnv).Dec 16 2021, 3:41 PM

Ankit Meel (ankitm) retitled this revision from Tiny fix to the valiant script build_files/build_environment/install_deps.sh ,updating the environment variables to build OpenImageIO and OpenShadingLanguage. to install_deps: Fix OIIO and OSL build with OpenEXR.Dec 16 2021, 3:41 PM

Ankit Meel (ankitm) added 1 blocking reviewer(s): Bastien Montagne (mont29).

Bastien Montagne (mont29) added inline comments.Dec 17 2021, 4:22 PM

build_files/build_environment/install_deps.sh
2381	Are you sure this is needed here? Looks like `OPENEXR_ROOT_DIR` is the proper value for OSL...

Ray Molenkamp (LazyDodo) added inline comments.Dec 17 2021, 4:43 PM

build_files/build_environment/install_deps.sh
2381	unsure what version this changed, but recent versions of OSL's `checked_find_package` want the `PackageName_ROOT` format it emits a message telling the user about this format, this applies to all deps not just OpenEXR and is case sensitive

Will commit with some tweaks (mostly cleanups and consistency). Thanks.

build_files/build_environment/install_deps.sh
2381	Ah right... was just checking the `CHANGES.md` file at root which mentions the `OPENEXR_ROOT_DIR`, but fails to mention that newer convention!

This revision is now accepted and ready to land.Dec 17 2021, 5:42 PM

https://cmake.org/cmake/help/latest/envvar/PackageName_ROOT.html I am having to deal with cmake a bit, for the first time, and just found that ^
Learnt too thanks to that https://bastian.rieck.me/blog/posts/2018/cmake_tips/, that find_package() arg is case sensitive, that's why this "camel case' OpenEXR shows up, blame it on the guy that wrote the cmake find package call. Nothing is standardized on this build system this seems pretty awful.

Closed by commit rB5adc06d2d898: install_deps: Fix OIIO and OSL build with OpenEXR (authored by Maxime Chambonnet <Maxzor_2_what_the_fuck_blenderid>, committed by Bastien Montagne (mont29)). · Explain WhyDec 20 2021, 12:52 PM

This revision was automatically updated to reflect the committed changes.

Bastien Montagne (mont29) added a commit: rB5adc06d2d898: install_deps: Fix OIIO and OSL build with OpenEXR.