Details

Reviewers

Commits

rCf8dae8aaa26a: Make embree compact bvh optional
rBe2a36a6e459f: Cycles: Make Embree compact BVH optional

Summary

Make the Embree RTC_SCENE_FLAG_COMPACT flag optional and enabled per default.
Disabling this setting makes rendering a bit faster in some scenes at the cost of a higher memory usage.

Scene	Compact ON	Compact OFF
barbershop (50% resolution)	8:16min, 2280M peak	8:03min, 2318M peak
bmw	3:05min, 139M peak	2:57min, 153M peak
fishy_cat	4:04min, 518M peak	4:01min, 518M peak
junk_shop (50% resolution)	1:16min, 4724M peak	1:16min, 4972M peak
koro (50% resolution)	1:37min, 381M peak	1:37min, 381M peak
victor (50% resolution)	4:14min , 6485M peak	4:04min, 7397M peak
wdas_cloud	0:22min, 315M peak	0:22min, 315M peak

Reference: T73778

Memory increase is minimal in most scenes. Only victors shows some higher increase.

Diff Detail

Event Timeline

Thomas Dinges (dingto) requested review of this revision.Dec 16 2021, 11:17 AM

Thomas Dinges (dingto) created this revision.

Thomas Dinges (dingto) edited the summary of this revision. (Show Details)Dec 16 2021, 11:38 AM

Thomas Dinges (dingto) edited the summary of this revision. (Show Details)Dec 16 2021, 12:21 PM

Thomas Dinges (dingto) edited the summary of this revision. (Show Details)Dec 16 2021, 12:26 PM

Thomas Dinges (dingto) added a reviewer: Brecht Van Lommel (brecht).

The increase in memory usage seems significant enough to me that we should keep the BVH compact by default.

We also need to make it clear which devices these BVH options apply to, it's not clear this only affects CPU rendering.

This revision now requires changes to proceed.Dec 16 2021, 6:43 PM

Alaska (Alaska) added a subscriber: Alaska (Alaska).Dec 16 2021, 7:31 PM

Gilberto Rodrigues (gilberto_rodrigues) awarded a token.Dec 17 2021, 12:34 AM

Rebase to latest master
Enabled compact per default

The options inside the Acceleration Structure panel are:

Use Spatial Splits (CPU & GPU)
Use Hair BVH (GPU only)
Use Compact BVH (CPU only)
BVH Time Steps (GPU only & !spatial_splits)

We could just display the relevant ones and hide the others while CPU or GPU is selected?
CPU:

Use Spatial Splits
Use Compact BVH

GPU:

Use Spatial Splits
Use Hair BVH
BVH Time Steps

Should this be clarified further in the code too? Or just UI?

Alaska (Alaska) edited the summary of this revision. (Show Details)Dec 17 2021, 10:04 PM

Alaska (Alaska) edited the summary of this revision. (Show Details)

Showing only the relevant options make sense to me. The check should also take into account if CPU + GPU rendering and used. And also if OptiX is used, which doesn't use any of the options as far as I can tell.

Brecht Van Lommel (brecht) requested changes to this revision.Jan 19 2022, 6:32 PM

This revision now requires changes to proceed.Jan 19 2022, 6:32 PM

Rebase to latest master
Only show UI options, for devices that make use of them.

Todo: Take CPU + GPU into account.

Multi device is now taken into account. If the user selects a device with another type (in practise a CPU), the UI shows CPU rendering options as well.

This is ready now from my end. I'd commit the compact and UI changes as two separate commits.