Spreadsheet: Add material column for meshes
Changes PlannedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Dec 17 2021, 1:02 AM.

Details

Reviewers

Maniphest Tasks

Summary

Add a column to the face section of the spreadsheet showing what material
corresponds to each face, in addition to the existing index. This is
helpful because it displays the name, and eventually it could become a
drag and drop target.

I've noticed a use after free in some cases that I still want to investigate.

Diff Detail

Repository

rB Blender

Branch

spreadsheet-material-column (branched from master)

Build Status

Buildable 19498
Build 19498: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Dec 17 2021, 1:02 AM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B19498: Diff 46139.Dec 17 2021, 1:02 AM

Hans Goudey (HooglyBoogly) added a project: Geometry Nodes.Dec 17 2021, 1:02 AM

Hans Goudey (HooglyBoogly) added a task: T93744: Material names in spreadsheet.

Jacques Lucke (JacquesLucke) added a subscriber: Jacques Lucke (JacquesLucke).Dec 17 2021, 11:06 AM

Jacques Lucke (JacquesLucke) added inline comments.

source/blender/editors/space_spreadsheet/spreadsheet_data_source_geometry.cc
154	This has to check for the face domain.

Add check for face domain
Add check for empty material list

Harbormaster completed remote builds in B19524: Diff 46188.Dec 18 2021, 12:54 AM

Your comment in D13605 made me wonder if we should think about that here too, since these materials aren't stored, they're calculated from the indices and the material list. Maybe having some vertical divider, and then a way to toggle these columns on and off with a popover would be nice. That would solve the current weirdness with instance rotation and scale columns too.

Hans Goudey (HooglyBoogly) added a reviewer: Jacques Lucke (JacquesLucke).Dec 20 2021, 2:11 PM

Jacques Lucke (JacquesLucke) accepted this revision.Dec 21 2021, 3:37 PM

This revision is now accepted and ready to land.Dec 21 2021, 3:37 PM

I think I haven't committed this for so long because I don't feel totally comfortable adding this derived data to the spreadsheet without any way of visually/conceptually separating it from the other columns. I think I'd rather have an idea of how that would work before committing this.

Iliya Katueshenock (Moder) added a subscriber: Iliya Katueshenock (Moder).Dec 25 2022, 7:47 PM