Fix T94162: Incorrect handling when there are multiple group outputs.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Dec 17 2021, 1:53 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T94162: Geometry Nodes repeatable crash when setting position

Commits

rBba4b7b43195c: Fix T94162: incorrect handling when there are multiple group outputs

Summary

Typically a node group should only have a single Group Output node. However, currently Blender already supports having multiple group outputs, one of which is active. This wasn't handled correctly by geometry nodes.

Diff Detail

Repository

rB Blender

Branch

use-active-group-output (branched from master)

Build Status

Buildable 19510
Build 19510: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Dec 17 2021, 1:53 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B19510: Diff 46161.Dec 17 2021, 1:53 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Dec 17 2021, 1:54 PM

Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).

Jacques Lucke (JacquesLucke) added a task: T94162: Geometry Nodes repeatable crash when setting position.

Make sense!

source/blender/nodes/NOD_node_tree_ref.hh
283	It might be helpful to add a comment here that this is the active group output node if there are multiple.
source/blender/nodes/intern/node_tree_ref.cc
124	`.first()`?