Page MenuHome
Differential D13620

Fix assert conditions in NURBSpline::knots method
ClosedPublic
Actions

Authored by Piotr Makal (pmakal) on Dec 18 2021, 8:26 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Commits
rB70de992afe92: Fix: Incorrect assert conditions in NURBSpline
Summary

This fix provide better conditions for asserts in NURBSpline::knots method accounting for cyclic NURBS curves.

Diff Detail

Repository
rB Blender

Event Timeline

Piotr Makal (pmakal) requested review of this revision.Dec 18 2021, 8:26 PM
Piotr Makal (pmakal) created this revision.
Hans Goudey (HooglyBoogly) accepted this revision.Dec 18 2021, 8:27 PM

Thanks, I'll commit this sometime soon (maybe on Monday though).

This revision is now accepted and ready to land.Dec 18 2021, 8:27 PM
Closed by commit rB70de992afe92: Fix: Incorrect assert conditions in NURBSpline (authored by Piotr Makal (pmakal), committed by Hans Goudey (HooglyBoogly)). · Explain WhyDec 20 2021, 7:43 PM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rB70de992afe92: Fix: Incorrect assert conditions in NURBSpline.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
4 lines

Diff 46239

View Options

source/blender/blenkernel/intern/spline_nurbs.cc

Loading...