Page MenuHome
Differential D13630

Fix T94243: weightpaint gradient panel shown in other places
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Dec 20 2021, 10:05 AM.

Details

Reviewers
Joseph Eagar (joeedh)
Campbell Barton (campbellbarton)
Maniphest Tasks
T94243: Spare falloff panel
Commits
rB21f02dd85d93: Fix T94243: weightpaint gradient panel shown in other places
rB5519a6a52062: Fix T94243: weightpaint gradient panel shown in other places
Summary

Weightpaint gradient tool panel showed in other modes (and as a separate
panel).

Fix for fix, see

So now, check mode again and restrict to topbar (prevents an additional
panel since this is already included in the brush settings).

ref rB0837926740b3 in sculpt-dev branch, so thx @Joseph Eagar (joeedh) as well!

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Dec 20 2021, 10:05 AM
Philipp Oeser (lichtwerk) created this revision.
Philipp Oeser (lichtwerk) added a task: T94243: Spare falloff panel.
Pratik Borhade (PratikPB2123) awarded a token.Dec 21 2021, 8:31 AM
Philipp Oeser (lichtwerk) mentioned this in T94243: Spare falloff panel.Dec 23 2021, 7:53 PM
Pratik Borhade (PratikPB2123) mentioned this in T94554: Spare falloff panel in properties.Jan 2 2022, 11:00 AM
Campbell Barton (campbellbarton) accepted this revision.Jan 9 2022, 7:12 AM

Looks fine, only minor changes noted.

release/scripts/startup/bl_ui/space_view3d_toolbar.py
697

Typo fraw also use capitals & fullstops.

698

Single quotes for enums (elsewhere in this patch too).

708–709

Prefer if settings is None: done elsewhere in this file.

This revision is now accepted and ready to land.Jan 9 2022, 7:12 AM
Closed by commit rB5519a6a52062: Fix T94243: weightpaint gradient panel shown in other places (authored by Philipp Oeser (lichtwerk)). · Explain WhyJan 9 2022, 11:39 AM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB5519a6a52062: Fix T94243: weightpaint gradient panel shown in other places.
Philipp Oeser (lichtwerk) added a commit: rB21f02dd85d93: Fix T94243: weightpaint gradient panel shown in other places.Jan 11 2022, 9:33 AM

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
10 lines

Diff 46222

View Options

release/scripts/startup/bl_ui/space_view3d_toolbar.py

Loading...