Differential D13631

Fix T94262: Grease Pencil Blur Effect DoF mode wrong
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Dec 20 2021, 12:20 PM.

Tags

Subscribers

Clément Foucault (fclem)

Details

Reviewers

Antonio Vazquez (antoniov)

Maniphest Tasks

T94262: Grease Pencil Blur Effect "Use Depth of Field" visible in cameras NOT using DoF

Commits

rB8b4d0d733831: Fix T94262: Grease Pencil Blur Effect DoF mode wrong
rB20d0cddc608a: Fix T94262: Grease Pencil Blur Effect DoF mode wrong
rB59221476b0d4: Fix T94262: Grease Pencil Blur Effect DoF mode wrong

Summary

This was visible outside of camera view and was not respecting the
"Depth of Field" checkbox on the Camera properties.

Now return early if DoF should not be visible.

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Dec 20 2021, 12:20 PM

Philipp Oeser (lichtwerk) created this revision.

Philipp Oeser (lichtwerk) added a task: T94262: Grease Pencil Blur Effect "Use Depth of Field" visible in cameras NOT using DoF.

LGTM, but not sure if @Clément Foucault (fclem) has any comment about this.

This revision is now accepted and ready to land.Dec 20 2021, 1:12 PM

Closed by commit rB59221476b0d4: Fix T94262: Grease Pencil Blur Effect DoF mode wrong (authored by Philipp Oeser (lichtwerk)). · Explain WhyDec 20 2021, 10:03 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB59221476b0d4: Fix T94262: Grease Pencil Blur Effect DoF mode wrong.

Philipp Oeser (lichtwerk) added a commit: rB20d0cddc608a: Fix T94262: Grease Pencil Blur Effect DoF mode wrong.Jan 11 2022, 4:00 PM

Philipp Oeser (lichtwerk) added a commit: rB8b4d0d733831: Fix T94262: Grease Pencil Blur Effect DoF mode wrong.Jan 18 2022, 10:54 AM

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

gpencil/

gpencil_shader_fx.c

7 lines

Diff 46224

source/blender/draw/engines/gpencil/gpencil_shader_fx.c

Loading...