Page MenuHome

GPencil Subdivision value is not consistent with Box primitive and does not work with wheelmouse as expected
ClosedPublic

Authored by Antonio Vazquez (antoniov) on Dec 20 2021, 4:53 PM.

Details

Summary

The problem was the number of points for each edge of the box was wrong and the wheelmouse effect was anulated.

Diff Detail

Repository
rB Blender
Branch
temp-T93999 (branched from master)
Build Status
Buildable 19561
Build 19561: arc lint + arc unit

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.Dec 20 2021, 4:53 PM
Antonio Vazquez (antoniov) created this revision.
Philipp Oeser (lichtwerk) requested changes to this revision.Dec 21 2021, 12:57 PM

If I now start with 0 subdivisions in the UI, I start of the modal with two edges [also seen in the status bar], dont think this is intentional?
(mousewheel works fine though... so I could decrease to one [from 2] and up again)

This revision now requires changes to proceed.Dec 21 2021, 12:57 PM
  • Make more coherent the values of subdivisions and avoid 0

    Now the subdivision minimum value is 1 instead of 0 because the primitives use this value as number of segments.

    Not sure if the name "subdivision" is the best in the UI, because maybe would be relative to number of segments.
  • More tweaks to values
  • Missing in previous commit

With the current version, I still get the discrepancy of starting with 0 subdivisions in the UI and getting 1 subdivisions reported in the statusbar.
I know the "end-result" is now in fact 0 subdivisions (which is good), going up and down with the mousewheel also works, maybe we could avoid the confusion by tweaking the statusbar to be the same as the Subdivisions in the topbar?
I know edges and subdivisions are not the same, but since "edges" are only internal, maybe we should stick to only subdivisions in the "user-visble" UI?

Also, please update the Diff title to be something more descriptive.
Thx, we are getting there

The value in the status bar looks the number of edges... this was like that since first implementation... I will change it to reflect subdivision value.

Antonio Vazquez (antoniov) retitled this revision from Fix T93999 to GPencil Subdivision value is not consistent with Box primitive and does not work with wheelmouse as expected.Dec 22 2021, 1:17 PM
  • Display current subdivision value in status bar
This revision is now accepted and ready to land.Dec 22 2021, 1:58 PM