"Invert Arc" might be a more intuitive and more consistent than "Shortest Arc", and that would even work in radius mode

"Radius" can be the default mode, since it's a bit easier to understand and much smaller

Also, there seems to be a special case with weird behavior here:

Address comments.

Replace Shortest Arc with Invert Arc.
Set Radius mode as default.
Fix bug in points mode. Remove code based on slerp and do simple rotate around center point.
Set Normal to always be relative to Z axis.

Harbormaster completed remote builds in B19959: Diff 47017.Jan 13 2022, 2:57 AM

Testing this, it looks good to me now, I like the options that are exposed.

I'm curious, do you think the circle primitive's create_point_circle_curve function could be easily defined in terms of this one now? It might be nice to do some cleanup after this if possible.

source/blender/nodes/geometry/nodes/node_geo_curve_primitive_arc.cc
76–84	Candidates for descriptions: `The center of the circle described by the three points` `The normal direction of the plane described by the three points, pointing towards the positive Z axis` `The radius of the circle described by the three points`
192–206	I found this a little hard to follow at first, and my instinct was to separate it into a separate function, but I don't see a great way to make that work. Maybe it deserves a comment like "Find the two points that are furthest away from each other"
329–330	Use `node_storage` function, call the variable `storage` for consistency

This revision is now accepted and ready to land.Jan 20 2022, 6:39 PM

Charlie Jolly (charlie) marked 3 inline comments as done.Jan 20 2022, 7:36 PM

Address comments.

Harbormaster completed remote builds in B20097: Diff 47291.Jan 20 2022, 7:43 PM

In D13640#368585, @Hans Goudey (HooglyBoogly) wrote:

I'm curious, do you think the circle primitive's create_point_circle_curve function could be easily defined in terms of this one now? It might be nice to do some cleanup after this if possible.

Yes, I can take a look.

Closed by commit rBcc1a48e39514: Geometry Nodes: Curve Primitive Arc (authored by Charlie Jolly (charlie)). · Explain WhyJan 20 2022, 8:04 PM

This revision was automatically updated to reflect the committed changes.

Charlie Jolly (charlie) added a commit: rBcc1a48e39514: Geometry Nodes: Curve Primitive Arc.

Duarte Farrajota Ramos (duarteframos) awarded a token.Jan 20 2022, 9:18 PM

Geometry Nodes: Curve Primitive Arc
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 47292

release/scripts/startup/nodeitems_builtins.py

source/blender/blenkernel/BKE_node.h

source/blender/blenkernel/intern/node.cc

source/blender/blenlib/BLI_math_vector.hh

source/blender/makesdna/DNA_node_types.h

source/blender/makesrna/intern/rna_nodetree.c

source/blender/nodes/NOD_geometry.h

source/blender/nodes/NOD_static_types.h

source/blender/nodes/geometry/CMakeLists.txt

source/blender/nodes/geometry/nodes/node_geo_curve_primitive_arc.cc

Geometry Nodes: Curve Primitive ArcClosedPublicActions