Page MenuHome

Graph Slider Ops: Show error when no valid keys are found
ClosedPublic

Authored by Christoph Lendenfeld (ChrisLend) on Dec 22 2021, 9:41 PM.

Details

Summary

When using graph slider operators like D9374 it showed a warning when no keys were selected.

However since that stops the modal operation it should be an Error.

Also the message was misleading since it could error for different reasons than stated.

Diff Detail

Repository
rB Blender

Event Timeline

Christoph Lendenfeld (ChrisLend) requested review of this revision.Dec 22 2021, 9:41 PM
Christoph Lendenfeld (ChrisLend) created this revision.

Tiniest of nags, no need to re-review.

source/blender/editors/space_graph/graph_slider_ops.c
316

I'd remove the "valid" from the message; apart from keyframes that have NaN as coordinate they all are pretty much valid.

Cannot find valid keys or Cannot find keys to operate on would both basically communicate the same thing; having both "valid" and "to operate on" in the same sentence is redundant. And to solve that I'd go for the more plain English "to operate on" ;-)

This revision is now accepted and ready to land.Dec 23 2021, 11:08 AM