Nodes: Support linking to existing group input from link drag search.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Dec 27 2021, 12:01 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Commits

rB31e120ef4997: Nodes: Support linking to existing group input from link drag search.

Summary

Before one could only create a new group input using the link drag search. With this patch it becomes possible to create a Group Input node for an existing input.

Diff Detail

Repository

rB Blender

Branch

link-group-input (branched from master)

Build Status

Buildable 19641
Build 19641: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Dec 27 2021, 12:01 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B19641: Diff 46406.Dec 27 2021, 12:01 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Dec 27 2021, 12:15 PM

Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).

improve weights

Harbormaster completed remote builds in B19643: Diff 46408.Dec 27 2021, 12:16 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Dec 27 2021, 1:03 PM

This is a great improvement, and the code makes sense.

source/blender/editors/space_node/link_drag_search.cc
168	I think it would be reasonable to create a `nodes::GatherLinkSearchOpParams` and use `add_item` to avoid this duplication of the string wrangling. But it would make it necessary to look up the node type for the group input node, and it's a little less direct. So either way is fine with me.