Nodes: Cleanup: Remove no op registration functions
ClosedPublic
Actions

Authored by Aaron Carlisle (Blendify) on Dec 29 2021, 5:30 AM.

Details

Reviewers

Hans Goudey (HooglyBoogly)
Jacques Lucke (JacquesLucke)

Commits

rB465bd6651914: Nodes: Cleanup: Remove no op registration functions

Summary

All these function paramaters are set to NULL so they arent necessary.

Diff Detail

Repository

rB Blender

Branch

nodes-noop-reg-func (branched from master)

Build Status

Buildable 19673
Build 19673: arc lint + arc unit

Event Timeline

Aaron Carlisle (Blendify) requested review of this revision.Dec 29 2021, 5:30 AM

Aaron Carlisle (Blendify) created this revision.

Harbormaster completed remote builds in B19672: Diff 46454.Dec 29 2021, 5:30 AM

Aaron Carlisle (Blendify) added reviewers: Hans Goudey (HooglyBoogly), Jacques Lucke (JacquesLucke).Dec 29 2021, 5:31 AM

Missed one

Harbormaster completed remote builds in B19673: Diff 46455.Dec 29 2021, 5:35 AM

Good one!

This revision is now accepted and ready to land.Dec 29 2021, 5:52 AM

Jacques Lucke (JacquesLucke) accepted this revision.Dec 29 2021, 10:50 AM

Closed by commit rB465bd6651914: Nodes: Cleanup: Remove no op registration functions (authored by Aaron Carlisle (Blendify)). · Explain WhyDec 29 2021, 4:01 PM

This revision was automatically updated to reflect the committed changes.

Aaron Carlisle (Blendify) added a commit: rB465bd6651914: Nodes: Cleanup: Remove no op registration functions.

Revision Contents
Changeset List

Path

Size

source/

blender/

nodes/

shader/

nodes/

node_shader_add_shader.cc

2 lines

node_shader_ambient_occlusion.c

1 line

node_shader_background.c

2 lines

node_shader_bevel.c

1 line

node_shader_blackbody.c

2 lines

node_shader_brightness.c

2 lines

node_shader_bsdf_anisotropic.cc

1 line

node_shader_bsdf_diffuse.cc

2 lines

node_shader_bsdf_glass.cc

1 line

node_shader_bsdf_glossy.cc

1 line

node_shader_bsdf_hair.cc

2 lines

node_shader_bsdf_hair_principled.cc

1 line

node_shader_bsdf_principled.cc

1 line

node_shader_bsdf_refraction.cc

1 line

node_shader_bsdf_toon.cc

2 lines

node_shader_bsdf_translucent.cc

2 lines

node_shader_bsdf_transparent.cc

2 lines

node_shader_bsdf_velvet.cc

2 lines

node_shader_bump.cc

1 line

node_shader_camera.c

1 line

node_shader_displacement.c

1 line

node_shader_eevee_specular.c

2 lines

node_shader_emission.c

2 lines

node_shader_fresnel.c

2 lines

node_shader_gamma.c

2 lines

node_shader_geometry.c

2 lines

node_shader_hair_info.c

2 lines

node_shader_holdout.c

2 lines

node_shader_layer_weight.c

2 lines

node_shader_light_falloff.c

2 lines

node_shader_light_path.c

2 lines

node_shader_mix_shader.cc

2 lines

node_shader_output_light.c

2 lines

node_shader_output_linestyle.c

1 line

node_shader_output_material.c

2 lines

node_shader_output_world.c

2 lines

node_shader_shader_to_rgb.cc

2 lines

node_shader_squeeze.c

1 line

node_shader_subsurface_scattering.cc

1 line

node_shader_tex_coord.c

2 lines

node_shader_uv_along_stroke.c

1 line

node_shader_vector_displacement.c

1 line

node_shader_volume_absorption.cc

2 lines

node_shader_volume_principled.cc

1 line

node_shader_volume_scatter.cc

2 lines

node_shader_wavelength.c

2 lines

node_shader_wireframe.c

2 lines

texture/

nodes/

node_texture_coord.c

1 line

node_texture_distance.c

1 line

node_texture_math.c

1 line

Diff 46455

View Options

source/blender/nodes/shader/nodes/node_shader_add_shader.cc

View Options

source/blender/nodes/shader/nodes/node_shader_ambient_occlusion.c

View Options

source/blender/nodes/shader/nodes/node_shader_background.c

View Options

source/blender/nodes/shader/nodes/node_shader_bevel.c

View Options

source/blender/nodes/shader/nodes/node_shader_blackbody.c

View Options

source/blender/nodes/shader/nodes/node_shader_brightness.c

View Options

source/blender/nodes/shader/nodes/node_shader_bsdf_anisotropic.cc

View Options

source/blender/nodes/shader/nodes/node_shader_bsdf_diffuse.cc

View Options

source/blender/nodes/shader/nodes/node_shader_bsdf_glass.cc

View Options

source/blender/nodes/shader/nodes/node_shader_bsdf_glossy.cc

View Options

source/blender/nodes/shader/nodes/node_shader_bsdf_hair.cc

View Options

source/blender/nodes/shader/nodes/node_shader_bsdf_hair_principled.cc

View Options

source/blender/nodes/shader/nodes/node_shader_bsdf_principled.cc

View Options

source/blender/nodes/shader/nodes/node_shader_bsdf_refraction.cc

View Options

source/blender/nodes/shader/nodes/node_shader_bsdf_toon.cc

View Options

source/blender/nodes/shader/nodes/node_shader_bsdf_translucent.cc

View Options

source/blender/nodes/shader/nodes/node_shader_bsdf_transparent.cc

View Options

source/blender/nodes/shader/nodes/node_shader_bsdf_velvet.cc

View Options

source/blender/nodes/shader/nodes/node_shader_bump.cc

View Options

source/blender/nodes/shader/nodes/node_shader_camera.c

View Options

source/blender/nodes/shader/nodes/node_shader_displacement.c

View Options

source/blender/nodes/shader/nodes/node_shader_eevee_specular.c

View Options

source/blender/nodes/shader/nodes/node_shader_emission.c

View Options

source/blender/nodes/shader/nodes/node_shader_fresnel.c

View Options

source/blender/nodes/shader/nodes/node_shader_gamma.c

View Options

source/blender/nodes/shader/nodes/node_shader_geometry.c

View Options

source/blender/nodes/shader/nodes/node_shader_hair_info.c

View Options

source/blender/nodes/shader/nodes/node_shader_holdout.c

View Options

source/blender/nodes/shader/nodes/node_shader_layer_weight.c

View Options

source/blender/nodes/shader/nodes/node_shader_light_falloff.c

View Options

source/blender/nodes/shader/nodes/node_shader_light_path.c

View Options

source/blender/nodes/shader/nodes/node_shader_mix_shader.cc

View Options

source/blender/nodes/shader/nodes/node_shader_output_light.c

View Options

source/blender/nodes/shader/nodes/node_shader_output_linestyle.c

View Options

source/blender/nodes/shader/nodes/node_shader_output_material.c

View Options

source/blender/nodes/shader/nodes/node_shader_output_world.c

View Options

source/blender/nodes/shader/nodes/node_shader_shader_to_rgb.cc

View Options

source/blender/nodes/shader/nodes/node_shader_squeeze.c

View Options

source/blender/nodes/shader/nodes/node_shader_subsurface_scattering.cc

View Options

source/blender/nodes/shader/nodes/node_shader_tex_coord.c

View Options

source/blender/nodes/shader/nodes/node_shader_uv_along_stroke.c

View Options

source/blender/nodes/shader/nodes/node_shader_vector_displacement.c

View Options

source/blender/nodes/shader/nodes/node_shader_volume_absorption.cc

View Options

source/blender/nodes/shader/nodes/node_shader_volume_principled.cc

View Options

source/blender/nodes/shader/nodes/node_shader_volume_scatter.cc

View Options

source/blender/nodes/shader/nodes/node_shader_wavelength.c

View Options

source/blender/nodes/shader/nodes/node_shader_wireframe.c

View Options

source/blender/nodes/texture/nodes/node_texture_coord.c

View Options

source/blender/nodes/texture/nodes/node_texture_distance.c

View Options

source/blender/nodes/texture/nodes/node_texture_math.c

Nodes: Cleanup: Remove no op registration functionsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46455

source/blender/nodes/shader/nodes/node_shader_add_shader.cc

source/blender/nodes/shader/nodes/node_shader_ambient_occlusion.c

source/blender/nodes/shader/nodes/node_shader_background.c

source/blender/nodes/shader/nodes/node_shader_bevel.c

source/blender/nodes/shader/nodes/node_shader_blackbody.c

source/blender/nodes/shader/nodes/node_shader_brightness.c

source/blender/nodes/shader/nodes/node_shader_bsdf_anisotropic.cc

source/blender/nodes/shader/nodes/node_shader_bsdf_diffuse.cc

source/blender/nodes/shader/nodes/node_shader_bsdf_glass.cc

source/blender/nodes/shader/nodes/node_shader_bsdf_glossy.cc

source/blender/nodes/shader/nodes/node_shader_bsdf_hair.cc

source/blender/nodes/shader/nodes/node_shader_bsdf_hair_principled.cc

source/blender/nodes/shader/nodes/node_shader_bsdf_principled.cc

source/blender/nodes/shader/nodes/node_shader_bsdf_refraction.cc

source/blender/nodes/shader/nodes/node_shader_bsdf_toon.cc

source/blender/nodes/shader/nodes/node_shader_bsdf_translucent.cc

source/blender/nodes/shader/nodes/node_shader_bsdf_transparent.cc

source/blender/nodes/shader/nodes/node_shader_bsdf_velvet.cc

source/blender/nodes/shader/nodes/node_shader_bump.cc

source/blender/nodes/shader/nodes/node_shader_camera.c

source/blender/nodes/shader/nodes/node_shader_displacement.c

source/blender/nodes/shader/nodes/node_shader_eevee_specular.c

source/blender/nodes/shader/nodes/node_shader_emission.c

source/blender/nodes/shader/nodes/node_shader_fresnel.c

source/blender/nodes/shader/nodes/node_shader_gamma.c

source/blender/nodes/shader/nodes/node_shader_geometry.c

source/blender/nodes/shader/nodes/node_shader_hair_info.c

source/blender/nodes/shader/nodes/node_shader_holdout.c

source/blender/nodes/shader/nodes/node_shader_layer_weight.c

source/blender/nodes/shader/nodes/node_shader_light_falloff.c

source/blender/nodes/shader/nodes/node_shader_light_path.c

source/blender/nodes/shader/nodes/node_shader_mix_shader.cc

source/blender/nodes/shader/nodes/node_shader_output_light.c

source/blender/nodes/shader/nodes/node_shader_output_linestyle.c

source/blender/nodes/shader/nodes/node_shader_output_material.c

source/blender/nodes/shader/nodes/node_shader_output_world.c

source/blender/nodes/shader/nodes/node_shader_shader_to_rgb.cc

source/blender/nodes/shader/nodes/node_shader_squeeze.c

source/blender/nodes/shader/nodes/node_shader_subsurface_scattering.cc

source/blender/nodes/shader/nodes/node_shader_tex_coord.c

source/blender/nodes/shader/nodes/node_shader_uv_along_stroke.c

source/blender/nodes/shader/nodes/node_shader_vector_displacement.c

source/blender/nodes/shader/nodes/node_shader_volume_absorption.cc

source/blender/nodes/shader/nodes/node_shader_volume_principled.cc

source/blender/nodes/shader/nodes/node_shader_volume_scatter.cc

source/blender/nodes/shader/nodes/node_shader_wavelength.c

source/blender/nodes/shader/nodes/node_shader_wireframe.c

source/blender/nodes/texture/nodes/node_texture_coord.c

source/blender/nodes/texture/nodes/node_texture_distance.c

source/blender/nodes/texture/nodes/node_texture_math.c

Nodes: Cleanup: Remove no op registration functions
ClosedPublic
Actions

Revision Contents
Changeset List