Nodes: Convert several shader nodes to c++
ClosedPublic
Actions

Authored by Aaron Carlisle (Blendify) on Dec 30 2021, 4:39 AM.

Details

Reviewers: None
Commits: rB367fc69dc1c5: Nodes: Convert several shader nodes to c++
rBee2b72fd29f7: Nodes: Convert several shader nodes to c++

Summary

Also add file namespace

This is needed to use new node APIs

Diff Detail

Repository

rB Blender

Branch

nodes-shader-cpp (branched from master)

Build Status

Buildable 19689
Build 19689: arc lint + arc unit

Event Timeline

Aaron Carlisle (Blendify) requested review of this revision.Dec 30 2021, 4:39 AM

Aaron Carlisle (Blendify) created this revision.

Harbormaster completed remote builds in B19682: Diff 46474.Dec 30 2021, 4:39 AM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 30 2021, 6:42 PM

Closed by commit rBee2b72fd29f7: Nodes: Convert several shader nodes to c++ (authored by Aaron Carlisle (Blendify)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Aaron Carlisle (Blendify) added a commit: rBee2b72fd29f7: Nodes: Convert several shader nodes to c++.

Aaron Carlisle (Blendify) reopened this revision.Dec 30 2021, 8:02 PM

Merge branch 'master' into nodes-shader-cpp
Cleanup: Nodes: Convert several shader nodes to c++

Harbormaster completed remote builds in B19689: Diff 46484.Dec 30 2021, 8:03 PM

Fix windows build

Harbormaster completed remote builds in B19690: Diff 46485.Dec 30 2021, 8:25 PM

Restore bounds check, see D6102

Harbormaster completed remote builds in B19692: Diff 46487.Dec 30 2021, 9:40 PM

Cleanup: return in else statement

Harbormaster completed remote builds in B19693: Diff 46488.Dec 30 2021, 9:51 PM

Simplify check

Harbormaster completed remote builds in B19694: Diff 46489.Dec 30 2021, 9:54 PM

Merge branch 'master' into nodes-shader-cpp

Harbormaster completed remote builds in B19703: Diff 46500.Dec 31 2021, 6:12 PM

https://builder.blender.org/admin/#/builders/18/builds/248

Buildbot currently has issues on Linux but patch builds and test pass locally builds on mac also pass, build fails for unrelated issues.

The patch is good to go.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 3 2022, 5:45 AM

Closed by commit rB367fc69dc1c5: Nodes: Convert several shader nodes to c++ (authored by Aaron Carlisle (Blendify)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Aaron Carlisle (Blendify) added a commit: rB367fc69dc1c5: Nodes: Convert several shader nodes to c++.

Revision Contents
Changeset List

Path

Size

source/

blender/

nodes/

shader/

CMakeLists.txt

40 lines

nodes/

node_shader_hair_info.c

	node_shader_hair_info.cc
	node_shader_hair_info.c

12 lines

node_shader_holdout.c

	node_shader_holdout.cc
	node_shader_holdout.c

12 lines

node_shader_hueSatVal.c

	node_shader_hueSatVal.cc
	node_shader_hueSatVal.c

14 lines

node_shader_invert.c

	node_shader_invert.cc
	node_shader_invert.c

14 lines

node_shader_layer_weight.c

	node_shader_layer_weight.cc
	node_shader_layer_weight.c

15 lines

node_shader_light_falloff.c

	node_shader_light_falloff.cc
	node_shader_light_falloff.c

13 lines

node_shader_light_path.c

	node_shader_light_path.cc
	node_shader_light_path.c

12 lines

node_shader_mapping.c

	node_shader_mapping.cc
	node_shader_mapping.c

14 lines

node_shader_normal.c

	node_shader_normal.cc
	node_shader_normal.c

14 lines

node_shader_normal_map.c

	node_shader_normal_map.cc
	node_shader_normal_map.c

30 lines

node_shader_object_info.c

	node_shader_object_info.cc
	node_shader_object_info.c

12 lines

node_shader_output_aov.c

	node_shader_output_aov.cc
	node_shader_output_aov.c

16 lines

node_shader_output_light.c

	node_shader_output_light.cc
	node_shader_output_light.c

10 lines

node_shader_output_linestyle.c

	node_shader_output_linestyle.cc
	node_shader_output_linestyle.c

10 lines

node_shader_output_material.c

	node_shader_output_material.cc
	node_shader_output_material.c

12 lines

node_shader_output_world.c

	node_shader_output_world.cc
	node_shader_output_world.c

12 lines

node_shader_particle_info.c

	node_shader_particle_info.cc
	node_shader_particle_info.c

15 lines

node_shader_rgb.c

	node_shader_rgb.cc
	node_shader_rgb.c

12 lines

node_shader_script.c

	node_shader_script.cc
	node_shader_script.c

23 lines

node_shader_sepcomb_hsv.c

	node_shader_sepcomb_hsv.cc
	node_shader_sepcomb_hsv.c

28 lines

Diff 46484

View Options

source/blender/nodes/shader/CMakeLists.txt

View Options

source/blender/nodes/shader/nodes/node_shader_hair_info.c

View Options

source/blender/nodes/shader/nodes/node_shader_hair_info.cc

View Options

source/blender/nodes/shader/nodes/node_shader_holdout.c

View Options

source/blender/nodes/shader/nodes/node_shader_holdout.cc

View Options

source/blender/nodes/shader/nodes/node_shader_hueSatVal.c

View Options

source/blender/nodes/shader/nodes/node_shader_hueSatVal.cc

View Options

source/blender/nodes/shader/nodes/node_shader_invert.c

View Options

source/blender/nodes/shader/nodes/node_shader_invert.cc

View Options

source/blender/nodes/shader/nodes/node_shader_layer_weight.c

View Options

source/blender/nodes/shader/nodes/node_shader_layer_weight.cc

View Options

source/blender/nodes/shader/nodes/node_shader_light_falloff.c

View Options

source/blender/nodes/shader/nodes/node_shader_light_falloff.cc

View Options

source/blender/nodes/shader/nodes/node_shader_light_path.c

View Options

source/blender/nodes/shader/nodes/node_shader_light_path.cc

View Options

source/blender/nodes/shader/nodes/node_shader_mapping.c

View Options

source/blender/nodes/shader/nodes/node_shader_mapping.cc

View Options

source/blender/nodes/shader/nodes/node_shader_normal.c

View Options

source/blender/nodes/shader/nodes/node_shader_normal.cc

View Options

source/blender/nodes/shader/nodes/node_shader_normal_map.c

View Options

source/blender/nodes/shader/nodes/node_shader_normal_map.cc

View Options

source/blender/nodes/shader/nodes/node_shader_object_info.c

View Options

source/blender/nodes/shader/nodes/node_shader_object_info.cc

View Options

source/blender/nodes/shader/nodes/node_shader_output_aov.c

View Options

source/blender/nodes/shader/nodes/node_shader_output_aov.cc

View Options

source/blender/nodes/shader/nodes/node_shader_output_light.c

View Options

source/blender/nodes/shader/nodes/node_shader_output_light.cc

View Options

source/blender/nodes/shader/nodes/node_shader_output_linestyle.c

View Options

source/blender/nodes/shader/nodes/node_shader_output_linestyle.cc

View Options

source/blender/nodes/shader/nodes/node_shader_output_material.c

View Options

source/blender/nodes/shader/nodes/node_shader_output_material.cc

View Options

source/blender/nodes/shader/nodes/node_shader_output_world.c

View Options

source/blender/nodes/shader/nodes/node_shader_output_world.cc

View Options

source/blender/nodes/shader/nodes/node_shader_particle_info.c

View Options

source/blender/nodes/shader/nodes/node_shader_particle_info.cc

View Options

source/blender/nodes/shader/nodes/node_shader_rgb.c

View Options

source/blender/nodes/shader/nodes/node_shader_rgb.cc

View Options

source/blender/nodes/shader/nodes/node_shader_script.c

View Options

source/blender/nodes/shader/nodes/node_shader_script.cc

View Options

source/blender/nodes/shader/nodes/node_shader_sepcomb_hsv.c

View Options

source/blender/nodes/shader/nodes/node_shader_sepcomb_hsv.cc

Nodes: Convert several shader nodes to c++ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46484

source/blender/nodes/shader/CMakeLists.txt

source/blender/nodes/shader/nodes/node_shader_hair_info.c

source/blender/nodes/shader/nodes/node_shader_hair_info.cc

source/blender/nodes/shader/nodes/node_shader_holdout.c

source/blender/nodes/shader/nodes/node_shader_holdout.cc

source/blender/nodes/shader/nodes/node_shader_hueSatVal.c

source/blender/nodes/shader/nodes/node_shader_hueSatVal.cc

source/blender/nodes/shader/nodes/node_shader_invert.c

source/blender/nodes/shader/nodes/node_shader_invert.cc

source/blender/nodes/shader/nodes/node_shader_layer_weight.c

source/blender/nodes/shader/nodes/node_shader_layer_weight.cc

source/blender/nodes/shader/nodes/node_shader_light_falloff.c

source/blender/nodes/shader/nodes/node_shader_light_falloff.cc

source/blender/nodes/shader/nodes/node_shader_light_path.c

source/blender/nodes/shader/nodes/node_shader_light_path.cc

source/blender/nodes/shader/nodes/node_shader_mapping.c

source/blender/nodes/shader/nodes/node_shader_mapping.cc

source/blender/nodes/shader/nodes/node_shader_normal.c

source/blender/nodes/shader/nodes/node_shader_normal.cc

source/blender/nodes/shader/nodes/node_shader_normal_map.c

source/blender/nodes/shader/nodes/node_shader_normal_map.cc

source/blender/nodes/shader/nodes/node_shader_object_info.c

source/blender/nodes/shader/nodes/node_shader_object_info.cc

source/blender/nodes/shader/nodes/node_shader_output_aov.c

source/blender/nodes/shader/nodes/node_shader_output_aov.cc

source/blender/nodes/shader/nodes/node_shader_output_light.c

source/blender/nodes/shader/nodes/node_shader_output_light.cc

source/blender/nodes/shader/nodes/node_shader_output_linestyle.c

source/blender/nodes/shader/nodes/node_shader_output_linestyle.cc

source/blender/nodes/shader/nodes/node_shader_output_material.c

source/blender/nodes/shader/nodes/node_shader_output_material.cc

source/blender/nodes/shader/nodes/node_shader_output_world.c

source/blender/nodes/shader/nodes/node_shader_output_world.cc

source/blender/nodes/shader/nodes/node_shader_particle_info.c

source/blender/nodes/shader/nodes/node_shader_particle_info.cc

source/blender/nodes/shader/nodes/node_shader_rgb.c

source/blender/nodes/shader/nodes/node_shader_rgb.cc

source/blender/nodes/shader/nodes/node_shader_script.c

source/blender/nodes/shader/nodes/node_shader_script.cc

source/blender/nodes/shader/nodes/node_shader_sepcomb_hsv.c

source/blender/nodes/shader/nodes/node_shader_sepcomb_hsv.cc

Nodes: Convert several shader nodes to c++
ClosedPublic
Actions

Revision Contents
Changeset List