Fix T94526: Incorrect workspace ordering tooltip
ClosedPublic
Actions

Authored by Alaska (Alaska) on Dec 31 2021, 4:17 AM.

Details

Reviewers

Aaron Carlisle (Blendify)
Harley Acheson (harley)

Maniphest Tasks

T94526: Typo: Reorder to front / Reorder to back tooltip

Commits

rB34d424fd64bb: Fix T94526: Incorrect workspace ordering tooltip

Summary

Fix the description for WORKSPACE_OT_reorder_to_back to say "last" in
list rather than "first"

Hovering over a workspace tab, right-click for context menu. The list includes "Reorder to Back" but the tooltip description says "Reorder workspace to be first in the list". This patch changes it to say "Reorder workspace to be last in the list"

Diff Detail

Repository

rB Blender

Branch

fix-T94526 (branched from master)

Build Status

Buildable 19698
Build 19698: arc lint + arc unit

Event Timeline

Alaska (Alaska) requested review of this revision.Dec 31 2021, 4:17 AM

Alaska (Alaska) created this revision.

Harbormaster completed remote builds in B19698: Diff 46494.Dec 31 2021, 4:17 AM

Alaska (Alaska) added a task: T94526: Typo: Reorder to front / Reorder to back tooltip.Dec 31 2021, 4:18 AM

Aaron Carlisle (Blendify) accepted this revision.Dec 31 2021, 6:09 AM

This revision is now accepted and ready to land.Dec 31 2021, 6:09 AM

Superlative is preceded by "the" I guess: last -> the last

Alaska (Alaska) retitled this revision from Fix T94526: Grammar error in workspace ordering to Fix T94526: Incorrect tooltip in workspace ordering.Dec 31 2021, 9:01 PM

Include changes requested by ankitm

Harbormaster completed remote builds in B19847: Diff 46773.Jan 9 2022, 3:13 AM

In D13696#364864, @Alaska (Alaska) wrote:

Include changes requested by ankitm

Since this hasn't landed, I really hope you have not been waiting for me to "accept" the patch.. I would have blocked it if I wanted that to happen.

In D13696#366930, @Ankit Meel (ankitm) wrote:

Since this hasn't landed, I really hope you have not been waiting for me to "accept" the patch.. I would have blocked it if I wanted that to happen.

I don't have the ability to commit this patch, so I have been waiting for someone else to do it. I'm not sure if last or the last is the preferred change for this patch, so I just went with your suggestion of using the last.

@Alaska (Alaska) - I'm not sure if last or the last is the preferred change for this patch…

They are both equally right because “Last” can be a noun or adjective. It’s the same for First and ordinal numbers too. Both sound about the same, are used interchangeably, and are considered correct. I’d just select the shorter as that has slightly decreased complexity.

Follow the advice of @Harley Acheson (harley)

Harbormaster completed remote builds in B20016: Diff 47099.Jan 16 2022, 6:31 AM

Will commit.

Harley Acheson (harley) edited the summary of this revision. (Show Details)Jan 17 2022, 12:20 AM

Harley Acheson (harley) retitled this revision from Fix T94526: Incorrect tooltip in workspace ordering to Fix T94526: Incorrect workspace ordering tooltip.

Closed by commit rB34d424fd64bb: Fix T94526: Incorrect workspace ordering tooltip (authored by Alaska (Alaska), committed by Harley Acheson (harley)). · Explain WhyJan 17 2022, 12:27 AM

This revision was automatically updated to reflect the committed changes.

Harley Acheson (harley) added a commit: rB34d424fd64bb: Fix T94526: Incorrect workspace ordering tooltip.