Page MenuHome

Cleanup: Remove bNodeType flag from base registration functions
ClosedPublic

Authored by Aaron Carlisle (Blendify) on Dec 31 2021, 7:48 PM.

Details

Summary

This flag is only used a few small cases, so instead
of setting the flag for every node only set the
required flag for the nodes that require it.

Mostly the flag is used to set ntype.flag = NODE_PREVIEW
For nodes that should have previews by default which
is only some compositor nodes and some texture nodes.

The frame node also sets the NODE_BACKGROUND flag.

All other nodes were setting a flag of 0 which has no purpose.

Diff Detail

Repository
rB Blender
Branch
nodes-base-flag (branched from master)
Build Status
Buildable 19736
Build 19736: arc lint + arc unit

Event Timeline

Aaron Carlisle (Blendify) requested review of this revision.Dec 31 2021, 7:48 PM
Aaron Carlisle (Blendify) created this revision.
source/blender/nodes/composite/nodes/node_composite_channelMatte.cc
107

Setting flags should be done with |= in case cmp_node_type_base decides to set another flag in the future.

  • Merge branch 'master' into nodes-base-flag
  • Use bit wise or function to set flag
This revision is now accepted and ready to land.Jan 3 2022, 12:49 PM
  • Merge branch 'master' into nodes-shader-cpp
  • Fix build after merge