After disconnecting hair on an object, if you then hide the particle system, and try connecting the hair again, the operator is cancelled due to remap_hair_emitter returning false because target_psmd->mesh_final is NULL, but connect_hair will still strip the PSYS_GLOBAL_HAIR flag, which will cause the hair in the hidden particle system to be positioned incorrectly. The correct behaviour is to strip the flag only if remap_hair_emitter succeeds.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
Just a side note: as you seem to be getting more active (nice!), it would make sense to use arc maybe?
https://wiki.blender.org/wiki/Tools/CodeReview#Use_Arcanist
Main reason I am saying this is that (besides making submitting patches a bit easier) it gives context in the Diffs by default (so you can see more of the surrounding code)
See the -U1000 here https://wiki.blender.org/wiki/Tools/CodeReview#Upload_a_Diff (1000 is the number of lines of context, less is fine, depending on the situation)
Comment Actions
Could it be we now have an issue disconnecting/connecting anyways?, see my comment in rB5dedb39d447b: Fix T54488: hair disconnect/reconnect not working with modifiers
ok is now never true (at least without modifiers)