Details

Reviewers: None
Maniphest Tasks: T82645: Tracking: unify data storage for camera intrinsics

Summary

Added lens distortion settings:

aspect
principal x, y
distortion model enumerator
radial distortion coefficients (k 1-4)
tangential distortion coefficients (p 1-2)

Lens distortion coefficients are added w.r.t respective distortion models.

Diff Detail

Repository

rB Blender

Branch

bhq-camera-data (branched from master)

Build Status

Buildable 20240
Build 20240: arc lint + arc unit

Event Timeline

Ivan Perevala (ivpe) requested review of this revision.Jan 3 2022, 5:10 AM

Ivan Perevala (ivpe) created this revision.

Harbormaster completed remote builds in B19720: Diff 46527.Jan 3 2022, 5:10 AM

Ivan Perevala (ivpe) added a task: T82645: Tracking: unify data storage for camera intrinsics.Jan 3 2022, 10:45 AM

Hi, if you want this patch to be reviewed, you should set reviewer. Maybe sergey and jbakker?

@Raimund Klink (Raimund58), current commit is not completed, its just a remote mirror of my local branch. So I didnt assign any reviewer till its done.
I hope soon we can turn back to discussions about this implementations with module owners.

Merge branch 'master' into bhq-camera-data
Base refactor of relative MovieTracking data and BKE_ functions
Merge branch 'master' into bhq-camera-data

Harbormaster completed remote builds in B20136: Diff 47389.Jan 24 2022, 8:05 PM

Tweak lens and optical center for camera data-block in millimeters

Harbormaster completed remote builds in B20142: Diff 47397.Jan 24 2022, 10:58 PM

Update rna_tracking.c

Harbormaster completed remote builds in B20143: Diff 47399.Jan 24 2022, 11:06 PM

Remove unused DNA fields

Harbormaster completed remote builds in B20144: Diff 47402.Jan 25 2022, 1:40 AM

Ivan Perevala (ivpe) mentioned this in T82645: Tracking: unify data storage for camera intrinsics.Jan 28 2022, 3:50 PM

Update properties_data_camera.py
Merge branch 'master' into bhq-camera-data
Merge branch 'master' into bhq-camera-data
Update versioning_300.c

Harbormaster completed remote builds in B20240: Diff 47742.Jan 30 2022, 9:22 PM

Upd
Base refactor of cameras background images from list to single
Upd

Harbormaster completed remote builds in B20281: Diff 47836.Feb 1 2022, 7:30 PM

Base DNA and RNA expansion of Camera data-block for lens distortion parameters storage
Needs ReviewPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 47742

release/scripts/startup/bl_ui/properties_data_camera.py

release/scripts/startup/bl_ui/space_clip.py

source/blender/blenkernel/BKE_tracking.h

source/blender/blenkernel/intern/movieclip.c

source/blender/blenkernel/intern/tracking.c

source/blender/blenkernel/intern/tracking_solver.c

source/blender/blenkernel/intern/tracking_stabilize.c

source/blender/blenkernel/intern/tracking_util.c

source/blender/blenloader/intern/versioning_260.c

source/blender/blenloader/intern/versioning_300.c

source/blender/compositor/operations/COM_MovieDistortionOperation.h

source/blender/compositor/operations/COM_MovieDistortionOperation.cc

source/blender/editors/space_clip/clip_draw.c

source/blender/editors/space_clip/clip_editor.c

source/blender/editors/space_clip/clip_intern.h

source/blender/editors/space_clip/clip_utils.c

source/blender/editors/space_clip/space_clip.c

source/blender/editors/space_clip/tracking_ops.c

source/blender/makesdna/DNA_camera_defaults.h

source/blender/makesdna/DNA_camera_types.h

source/blender/makesdna/DNA_tracking_types.h

source/blender/makesdna/intern/dna_defaults.c

source/blender/makesrna/intern/rna_camera.c

source/blender/makesrna/intern/rna_tracking.c

Base DNA and RNA expansion of Camera data-block for lens distortion parameters storageNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47742

release/scripts/startup/bl_ui/properties_data_camera.py

release/scripts/startup/bl_ui/space_clip.py

source/blender/blenkernel/BKE_tracking.h

source/blender/blenkernel/intern/movieclip.c

source/blender/blenkernel/intern/tracking.c

source/blender/blenkernel/intern/tracking_solver.c

source/blender/blenkernel/intern/tracking_stabilize.c

source/blender/blenkernel/intern/tracking_util.c

source/blender/blenloader/intern/versioning_260.c

source/blender/blenloader/intern/versioning_300.c

source/blender/compositor/operations/COM_MovieDistortionOperation.h

source/blender/compositor/operations/COM_MovieDistortionOperation.cc

source/blender/editors/space_clip/clip_draw.c

source/blender/editors/space_clip/clip_editor.c

source/blender/editors/space_clip/clip_intern.h

source/blender/editors/space_clip/clip_utils.c

source/blender/editors/space_clip/space_clip.c

source/blender/editors/space_clip/tracking_ops.c

source/blender/makesdna/DNA_camera_defaults.h

source/blender/makesdna/DNA_camera_types.h

source/blender/makesdna/DNA_tracking_types.h

source/blender/makesdna/intern/dna_defaults.c

source/blender/makesrna/intern/rna_camera.c

source/blender/makesrna/intern/rna_tracking.c

Base DNA and RNA expansion of Camera data-block for lens distortion parameters storage
Needs ReviewPublic
Actions

Revision Contents
Changeset List