BGE: Add integer uniforms for 2D Filter
ClosedPublic
Actions

Authored by Thomas Szepe (hg1) on Jun 21 2015, 1:43 PM.

Details

Reviewers

Sybren A. Stüvel (sybren)
Porteries Tristan (panzergame)
Daniel Stokes (kupoman)
Jorge Bernal (lordloki)
Mitchell Stokes (moguri)
Angus Hollands (agoose77)

Commits

rBS97b431e42dd2: BGE: Add integer uniforms for 2D Filter
rB97b431e42dd2: BGE: Add integer uniforms for 2D Filter

Summary

Actually it is only possible to pass float properties to a 2D filter (GLSL fragment shader).
This patch allows also to use integer properties for the 2D filter.

Diff Detail

Repository: rB Blender

Event Timeline

Thomas Szepe (hg1) updated this revision to Diff 4466.Jun 21 2015, 1:43 PM

Thomas Szepe (hg1) retitled this revision from to BGE: Add integer uniforms for 2D Filter.

Thomas Szepe (hg1) updated this object.

Thomas Szepe (hg1) added reviewers: Mitchell Stokes (moguri), Porteries Tristan (panzergame), Jorge Bernal (lordloki), Sybren A. Stüvel (sybren), Angus Hollands (agoose77).

Thomas Szepe (hg1) added a project: Game Engine.

looks good to me.

This revision is now accepted and ready to land.Jun 21 2015, 1:51 PM

Mitchell Stokes (moguri) added a reviewer: Daniel Stokes (kupoman).Jun 22 2015, 2:36 AM

Looks good to me

As usual, I'm not a fan of silently failing, which happens if the property is not found. However, the old code also silently failed, so I don't think that is a blocking issue for this patch.

What happens if you declare a float in the shader, but then use an integer property? Will there be a failure? If so, are we concerned about breaking existing projects?

source/gameengine/Rasterizer/RAS_2DFilterManager.cpp
269	This is a minor nitpick, but I'd prefer to not declare variables in the middle of a scope. I also don't really see the point of storing the result of property->GetValueType() when we could do switch (property->GetValueType()) { And it still looks fine.