Differential D1371
Add Basic Tab Button Backend Authored by Julian Eisel (Severin) on Jun 22 2015, 1:11 AM.
Details Add Basic Tab Button BackendNOTE: This is really a backend-only implementation, nothing is changed in the UI
Adds a tab button-type and the basic drawing and handling code for it. This is not urgent to get into master, but I thought it might be better to add this separately before we actually use it. It's also the first step for some other projects I'd like to work on the next weeks.
Diff Detail
Event TimelineComment Actions Code seems fine but also not sure about applying it as-is,. Since improved thing/drawing is planned, with better arranged code (callbacks for button drawing), I'd prefer to postpone adding UI elements until thats done. OTOH, if important improvements depend on this patch giving real user benefits, then we can check on those, and it may be worth applying. Comment Actions Which exact goal we're trying to address with this patch? We can add all sort of weird and wonderful buttons, but at the same time it'll be cool to keep them all agreed with higher level user interface designs. Comment Actions @Campbell Barton (campbellbarton), as said, it's not really urgent, just would be good/handy to have this ready. I don't think the widget drawing refactor will take me that long, but adapting this to it should also be not that hard. @Sergey Sharybin (sergey), there are a couple of outstanding tab-button related projects (e.g. D667), having the backend ready and in master would just really help working on them. Also I think it's better to keep such commits (like adding a button type) separate from actual usage commits. Comment Actions Updating patch for latest master, also some minor adjustments and modified ID template to use tabs by default for testing (can be disabled in code). My plan was to merge this into blender2.8 branch soon where I could work on other tab related features. However, current button/widget code would require some hacks to make tabs work nicely (for aligning, checking of active value, etc) so it's probably better to see if we can improve general uiBut code first. Abandoning this, but I might pick it up later again. Comment Actions
So decided to push this to blender2.8, where we can use it for the topbar and improve it further. |