Page MenuHome
Differential D13724

Nishita sky: Increase max elevation to 360°
AbandonedPublic
Actions

Authored by Clément Foucault (fclem) on Jan 4 2022, 11:02 AM.

Details

Reviewers
Lukas Stockner (lukasstockner97)
William Reynish (billreynish)
Commits
rBad5e3d30a2d2: Nishita sky: Increase elevation range
Summary

The Nishita sky texture currently only allows moving the sun to the zenith. The problem is if you want to animate the passing of a full night-day-night cycle. Currently it's not easy to do due to this limitation.

The patch makes it so users can easily animate the sun moving from sunrise to sunset by expanding the max sun elevation to go 360° instead of 90°.

Diff Detail

Repository
rB Blender

Event Timeline

William Reynish (billreynish) requested review of this revision.Jan 4 2022, 11:02 AM
William Reynish (billreynish) created this revision.
Clément Foucault (fclem) requested changes to this revision.Jul 11 2022, 2:38 PM

I would allow [-π, +π] range for the UI but unlock the range to any angle for animation.

This revision now requires changes to proceed.Jul 11 2022, 2:38 PM
David Johnson (dlfon99) added a subscriber: David Johnson (dlfon99).Jul 11 2022, 11:54 PM
Clément Foucault (fclem) commandeered this revision.Jul 19 2022, 4:35 PM
Clément Foucault (fclem) edited reviewers, added: William Reynish (billreynish); removed: Clément Foucault (fclem).
This revision now requires review to proceed.Jul 19 2022, 4:35 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 19 2022, 4:36 PM
Closed by commit rBad5e3d30a2d2: Nishita sky: Increase elevation range (authored by Clément Foucault (fclem)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Clément Foucault (fclem) added a commit: rBad5e3d30a2d2: Nishita sky: Increase elevation range.
Arye Ramaty (BelgaratTheGrey) reopened this revision.Jul 25 2022, 5:02 PM
Arye Ramaty (BelgaratTheGrey) added a subscriber: Arye Ramaty (BelgaratTheGrey).
This comment was removed by Arye Ramaty (BelgaratTheGrey).
Arye Ramaty (BelgaratTheGrey) added a comment.Jul 25 2022, 5:09 PM

Using negative values on the Nishita sky texture elevation produces a weird-looking sun disc.
The bug:


Expected result:

Clément Foucault (fclem) added a comment.EditedJul 25 2022, 7:28 PM
In D13724#421294, @Arye Ramaty (BelgaratTheGrey) wrote:

Using negative values on the Nishita sky texture elevation produces a weird-looking sun disc.
The bug:


Expected result:

Thanks, this was fixed in rB46dbfce7fc59.

However, next time you encounter a bug, please fill a bug report. It makes it easier to track and avoid the issue going unnoticed.

Clément Foucault (fclem) abandoned this revision.Jul 25 2022, 8:43 PM

Revision Contents
Changeset List

PathSize
source/
blender/
makesrna/
intern/
2 lines

Diff 53808

View Options

source/blender/makesrna/intern/rna_nodetree.c

Loading...