Page MenuHome
Differential D13729

Depsgraph: fix spurious cycles with identically named idprops on bones.
ClosedPublic
Actions

Authored by Alexander Gavrilov (angavrilov) on Jan 4 2022, 12:30 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Commits
rB26e08cbeb885: Depsgraph: fix spurious cycles with identically named idprops on bones.
rB7bcf21e66e2e: Depsgraph: fix spurious cycles with identically named idprops on bones.
Summary

If multiple bones have a custom property with the same name,
depsgraph didn't distinguish between them, potentially leading
to spurious cycles.

This patch moves ID_PROPERTY operation nodes for bone custom
properties from the parameters component to individual bone
components, thus decoupling them.

Test file with a spurious cycle:

test-depsgraph-bone-idprops.blend95 KBDownload

Diff Detail

Repository
rB Blender
Branch
temp-angavrilov-depsgraph-idprops (branched from master)
Build Status
Buildable 19746
Build 19746: arc lint + arc unit

Event Timeline

Alexander Gavrilov (angavrilov) requested review of this revision.Jan 4 2022, 12:30 PM
Alexander Gavrilov (angavrilov) created this revision.
Harbormaster completed remote builds in B19746: Diff 46593.Jan 4 2022, 12:30 PM
Alexander Gavrilov (angavrilov) edited the summary of this revision. (Show Details)Jan 4 2022, 12:32 PM
Alexander Gavrilov (angavrilov) added a reviewer: Sergey Sharybin (sergey).
Sergey Sharybin (sergey) added a comment.Jan 5 2022, 2:47 PM

Seems nice and neat!
Did you have chance to test the change on something more of a production rig?

Alexander Gavrilov (angavrilov) added a comment.Jan 5 2022, 4:50 PM
In D13729#363737, @Sergey Sharybin (sergey) wrote:

Did you have chance to test the change on something more of a production rig?

Well, a rigify rig doesn't produce any errors in the console at least.

Sergey Sharybin (sergey) accepted this revision.Jan 6 2022, 12:04 PM

Lets go ahead with it then!
Just be around to keep an eye for possible something we didn't foresee ;)

This revision is now accepted and ready to land.Jan 6 2022, 12:04 PM
Closed by commit rB7bcf21e66e2e: Depsgraph: fix spurious cycles with identically named idprops on bones. (authored by Alexander Gavrilov (angavrilov)). · Explain WhyJan 6 2022, 2:43 PM
This revision was automatically updated to reflect the committed changes.
Alexander Gavrilov (angavrilov) added a commit: rB7bcf21e66e2e: Depsgraph: fix spurious cycles with identically named idprops on bones..
Sybren A. Stüvel (sybren) added a commit: rB26e08cbeb885: Depsgraph: fix spurious cycles with identically named idprops on bones..Dec 2 2022, 12:06 PM

Revision Contents
Changeset List

PathSize
source/
blender/
depsgraph/
intern/
builder/
7 lines
27 lines
13 lines
10 lines

Diff 46593

View Options

source/blender/depsgraph/intern/builder/deg_builder_nodes.h

Loading...
View Options

source/blender/depsgraph/intern/builder/deg_builder_nodes.cc

Loading...
View Options

source/blender/depsgraph/intern/builder/deg_builder_relations.cc

Loading...
View Options

source/blender/depsgraph/intern/builder/deg_builder_rna.cc

Loading...