Paths

Table of Contentst

Cleanup: Remove unused `node_type_exec` for shader node
ClosedPublic
Actions

Authored by Aaron Carlisle (Blendify) on Jan 4 2022, 11:58 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)
Jacques Lucke (JacquesLucke)
Brecht Van Lommel (brecht)

Commits

rBa0edee712a79: Cleanup: Remove unused `node_type_exec` for shader node

Summary

From what I can tell these are left over from Blender Internal render.

Test still pass locally.

Please pay attention also the node_shader_common file.
Readign commits suggest the code might be related to custom node trees.
However in Blender 3.0 or with the patch I do not see
how these functions are used for custom node trees.

Diff Detail

Repository

rB Blender

Branch

nodes-no-op-shader-exec (branched from master)

Build Status

Buildable 19768
Build 19768: arc lint + arc unit

Event Timeline

Aaron Carlisle (Blendify) requested review of this revision.Jan 4 2022, 11:58 PM

Aaron Carlisle (Blendify) created this revision.

Harbormaster completed remote builds in B19761: Diff 46611.Jan 4 2022, 11:58 PM

Aaron Carlisle (Blendify) edited the summary of this revision. (Show Details)Jan 4 2022, 11:58 PM

Aaron Carlisle (Blendify) added reviewers: Hans Goudey (HooglyBoogly), Jacques Lucke (JacquesLucke).

Build: https://builder.blender.org/admin/#/builders/18/builds/252

Merge branch 'master' into nodes-no-op-shader-exec
Cleanup: Remove ShaderCallData

Harbormaster completed remote builds in B19767: Diff 46621.Jan 5 2022, 5:29 AM

Aaron Carlisle (Blendify) added a reviewer: Brecht Van Lommel (brecht).Jan 5 2022, 5:33 AM

Cleanup: make nodestack_get_vec static

Harbormaster completed remote builds in B19768: Diff 46625.Jan 5 2022, 5:44 AM

Fine with me as long as the tests pass and you have tested that Eevee continues to work as well.

This revision is now accepted and ready to land.Jan 5 2022, 1:27 PM

Yup, both tests, and Eevee sill pass and function.

Jacques Lucke (JacquesLucke) accepted this revision.Jan 5 2022, 5:40 PM

Closed by commit rBa0edee712a79: Cleanup: Remove unused `node_type_exec` for shader node (authored by Aaron Carlisle (Blendify)). · Explain WhyJan 5 2022, 5:53 PM

This revision was automatically updated to reflect the committed changes.

Aaron Carlisle (Blendify) added a commit: rBa0edee712a79: Cleanup: Remove unused `node_type_exec` for shader node.

Charlie Jolly (charlie) mentioned this in T95221: Eevee: Float Curve node causes issues with compiled shader.Jan 27 2022, 6:12 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

nodes/

shader/

node_shader_util.hh

7 lines

node_shader_util.cc

2 lines

nodes/

node_shader_color_ramp.cc

20 lines

node_shader_common.cc

121 lines

node_shader_curves.cc

56 lines

node_shader_fresnel.cc

10 lines

node_shader_gamma.cc

18 lines

node_shader_hueSatVal.cc

40 lines

node_shader_invert.cc

26 lines

node_shader_layer_weight.cc

10 lines

node_shader_mix_rgb.cc

27 lines

node_shader_normal.cc

20 lines

node_shader_normal_map.cc

10 lines

node_shader_particle_info.cc

9 lines

node_shader_rgb_to_bw.cc

16 lines

node_shader_sepcomb_hsv.cc

30 lines

node_shader_sepcomb_rgb.cc

34 lines

node_shader_squeeze.cc

17 lines

node_shader_vector_transform.cc

10 lines

Diff 46625

View Options

source/blender/nodes/shader/node_shader_util.hh

View Options

source/blender/nodes/shader/node_shader_util.cc

View Options

source/blender/nodes/shader/nodes/node_shader_color_ramp.cc

View Options

source/blender/nodes/shader/nodes/node_shader_common.cc

View Options

source/blender/nodes/shader/nodes/node_shader_curves.cc

View Options

source/blender/nodes/shader/nodes/node_shader_fresnel.cc

View Options

source/blender/nodes/shader/nodes/node_shader_gamma.cc

View Options

source/blender/nodes/shader/nodes/node_shader_hueSatVal.cc

View Options

source/blender/nodes/shader/nodes/node_shader_invert.cc

View Options

source/blender/nodes/shader/nodes/node_shader_layer_weight.cc

View Options

source/blender/nodes/shader/nodes/node_shader_mix_rgb.cc

View Options

source/blender/nodes/shader/nodes/node_shader_normal.cc

View Options

source/blender/nodes/shader/nodes/node_shader_normal_map.cc

View Options

source/blender/nodes/shader/nodes/node_shader_particle_info.cc

View Options

source/blender/nodes/shader/nodes/node_shader_rgb_to_bw.cc

View Options

source/blender/nodes/shader/nodes/node_shader_sepcomb_hsv.cc

View Options

source/blender/nodes/shader/nodes/node_shader_sepcomb_rgb.cc

View Options

source/blender/nodes/shader/nodes/node_shader_squeeze.cc

View Options

source/blender/nodes/shader/nodes/node_shader_vector_transform.cc

Cleanup: Remove unused `node_type_exec` for shader nodeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46625

source/blender/nodes/shader/node_shader_util.hh

source/blender/nodes/shader/node_shader_util.cc

source/blender/nodes/shader/nodes/node_shader_color_ramp.cc

source/blender/nodes/shader/nodes/node_shader_common.cc

source/blender/nodes/shader/nodes/node_shader_curves.cc

source/blender/nodes/shader/nodes/node_shader_fresnel.cc

source/blender/nodes/shader/nodes/node_shader_gamma.cc

source/blender/nodes/shader/nodes/node_shader_hueSatVal.cc

source/blender/nodes/shader/nodes/node_shader_invert.cc

source/blender/nodes/shader/nodes/node_shader_layer_weight.cc

source/blender/nodes/shader/nodes/node_shader_mix_rgb.cc

source/blender/nodes/shader/nodes/node_shader_normal.cc

source/blender/nodes/shader/nodes/node_shader_normal_map.cc

source/blender/nodes/shader/nodes/node_shader_particle_info.cc

source/blender/nodes/shader/nodes/node_shader_rgb_to_bw.cc

source/blender/nodes/shader/nodes/node_shader_sepcomb_hsv.cc

source/blender/nodes/shader/nodes/node_shader_sepcomb_rgb.cc

source/blender/nodes/shader/nodes/node_shader_squeeze.cc

source/blender/nodes/shader/nodes/node_shader_vector_transform.cc

Cleanup: Remove unused `node_type_exec` for shader node
ClosedPublic
Actions

Revision Contents
Changeset List