Page MenuHome

Cleanup: Add `bf_nodes_texture` library
ClosedPublic

Authored by Aaron Carlisle (Blendify) on Jan 6 2022, 3:08 AM.

Details

Summary

For sake of consistencey with other node tree types, create its own cmake module.
This change helps keep bf_nodes focused on generic nodes files.

Texture nodes are end of life and hopefully for Blender 4.0 they can be removed.
It is not expected that these will see the updates that the other nodes are getting.
This change also helps isolate the end of life files, we may move some texture
specific node tree execution code out of node_exec and into a node_texture_exec files.

Diff Detail

Repository
rB Blender

Event Timeline

Aaron Carlisle (Blendify) requested review of this revision.Jan 6 2022, 3:08 AM
Aaron Carlisle (Blendify) created this revision.
Aaron Carlisle (Blendify) added inline comments.
source/blender/nodes/texture/CMakeLists.txt
72–84

Im not sure this is really needed?

Side note, with this change unity build could be enabled for bf_nodes however, I saw very little benefit, maybe 5% or about a second or two.

source/blender/nodes/texture/CMakeLists.txt
72–84

it's hard to tell given our cmake structure. i'd say leave it for now, and we'll do a cleanup pass once D12122 lands.

I triggered a patch build: https://builder.blender.org/admin/#/builders/18/builds/254

Assuming it passes, this patch looks good.

This revision is now accepted and ready to land.Jan 6 2022, 2:55 PM
This revision was automatically updated to reflect the committed changes.