Differential D13745
Native STL importer Authored by Iyad Ahmed (iyadahmed2001) on Jan 6 2022, 10:03 AM.
Details When importing large files, or many files in batch, the current STL importer is slow, An alternative solution is to write a new Python importer, but writing a native C or C++ importer brings better performance. This is intended to replace the Python importer, an exporter is also planned, better to split into a different patch.
Diff Detail
Event TimelineComment Actions I just realized the ASCII importer is not very robust with different whitespace types, I need to rewrite it Comment Actions A few notes
BLI_assert failed: F:\source\blender-git\blender\source\blender\bmesh\intern\bmesh_core.c:142, BM_edge_create(), at 'v1 != v2' blender.exe!_BLI_assert_abort() Line 61 C > blender.exe!BM_edge_create(BMesh * bm, BMVert * v1, BMVert * v2, const BMEdge * e_example, const eBMCreateFlag create_flag) Line 142 C blender.exe!BM_edges_from_verts_ensure(BMesh * bm, BMEdge * * edge_arr, BMVert * * vert_arr, const int len) Line 72 C blender.exe!BM_face_create_verts(BMesh * bm, BMVert * * vert_arr, const int len, const BMFace * f_example, const eBMCreateFlag create_flag, const bool create_edges) Line 489 C blender.exe!BM_face_create_quad_tri(BMesh * bm, BMVert * v1, BMVert * v2, BMVert * v3, BMVert * v4, const BMFace * f_example, const eBMCreateFlag create_flag) Line 91 C blender.exe!read_stl_binary(BMesh * bm, _iobuf * file, float[3] * mat, bool use_facet_normal, GHash * gh_float3) Line 139 C Comment Actions Fix some binary STLs misidentified as ASCII Comment Actions
Comment Actions Generally looks ok to me functionally and feature wise compared to the old importer now, thank you for addressing those prior comments. I'll defer to other reviewers for a final signoff and review though. Some further comments:
Comment Actions Awesome, will change the struct, many thanks for experimenting with binary importer, I guess I will make it buffered then This comment was removed by Iyad Ahmed (iyadahmed2001). This comment was removed by Iyad Ahmed (iyadahmed2001). Comment Actions What about Triangle structure alignment, I'm having issues getting the read to work with an array of triangles typedef struct Triangle {
float normal[3];
float v1[3];
float v2[3];
float v3[3];
uint16_t attribute_byte_count;
} Triangle;Comment Actions
Comment Actions Thank you for your submission. The approach in this patch should have been discussed before spending a lot of time on the code, though. There is a design task T68936 for a similar effort: to reimplement certain importers and exporters in C++. Most importantly: talk before coding. If you want to make sure your efforts are not in vain, discuss your ideas and their design, before spending a considerable amount of time on them. Please read through Contributing Code for more info on how to best get your contributions into Blender. Comment Actions Thanks for feedback, I asked on blender chat coders channels before, and got the illusion that STL was not being worked on yet Comment Actions I believe your implementation is only one so far, I believe there is no implementation for STL and PLY, just obj export and import are worked on. Comment Actions Yes but STL is planned as part of fast io gsoc project, and part of the obj importer design (it is designed in a way it can work with STL too) | ||||||