Page MenuHome

Fix T94635: Sculpt Smooth in Surface mode with Anchored Stroke crash
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Jan 6 2022, 11:37 AM.

Details

Summary

Sculpt Smooth in Surface mode (as opposed to Laplacian) needs a cache
initialized on first time. In anchored stroke mode with spherical falloff
this was skipped though (because this starts of with no PBVH nodes and
an early return checks for this) and first_time was set to false before
cache initialization.

Now move the cache initalization to happen earlier (same as the cache
initialization for automasking).

Diff Detail

Repository
rB Blender

Event Timeline

Sounds fine from explanation and code. But to me a bit hard to tell whether there are some underwater stones hidden around.
Just test the change, commit, and re-iterate if we have missed something :)

This revision is now accepted and ready to land.Jan 6 2022, 12:15 PM