Page MenuHome
Differential D13756

BLI_floatX: Add most missing constructors and operator
AbandonedPublic
Actions

Authored by Clément Foucault (fclem) on Jan 6 2022, 6:14 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Summary

This should have no side effect.

This reverse the dependency, with float2 being needed for float3 and
so on.

This is needed for extensive usage of these types in the draw engines.

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 19813
Build 19813: arc lint + arc unit

Event Timeline

Clément Foucault (fclem) requested review of this revision.Jan 6 2022, 6:14 PM
Clément Foucault (fclem) created this revision.
Harbormaster completed remote builds in B19809: Diff 46696.Jan 6 2022, 6:14 PM
Clément Foucault (fclem) updated this revision to Diff 46698.Jan 6 2022, 6:26 PM

Fix explicit constructors and comma operator usage.

Harbormaster completed remote builds in B19811: Diff 46698.Jan 6 2022, 6:26 PM
Clément Foucault (fclem) updated this revision to Diff 46700.Jan 6 2022, 7:31 PM
  • Remove explicit cast causing compilation errors, add array access and fix implicit cast in one spot
Harbormaster completed remote builds in B19812: Diff 46700.Jan 6 2022, 7:31 PM
Clément Foucault (fclem) updated this revision to Diff 46701.Jan 6 2022, 7:47 PM
  • Fix wrong asserts
Harbormaster completed remote builds in B19813: Diff 46701.Jan 6 2022, 7:47 PM
Jacques Lucke (JacquesLucke) accepted this revision.Jan 7 2022, 3:02 PM

Looks all fine given the current design of this math library.

This revision is now accepted and ready to land.Jan 7 2022, 3:02 PM
Clément Foucault (fclem) abandoned this revision.Jan 12 2022, 12:24 PM

This was abandoned in favor of D13791.

Revision Contents
Changeset List

PathSize
source/
blender/
blenlib/
183 lines
134 lines
186 lines
nodes/
shader/
nodes/
4 lines

Diff 46701

View Options

source/blender/blenlib/BLI_float2.hh

Loading...
View Options

source/blender/blenlib/BLI_float3.hh

Loading...
View Options

source/blender/blenlib/BLI_float4.hh

Loading...
View Options

source/blender/nodes/shader/nodes/node_shader_tex_noise.cc

Loading...