Details

Reviewers

Hans Goudey (HooglyBoogly)
Jacques Lucke (JacquesLucke)

Commits

rB14f6afb09003: Geometry Nodes: Expand the Boolean Math node

Summary

Boolean Math only has 3 basic logic gates: AND, OR and NOT.
This patch adds 6 additional logic gates for convenience and ease of use:

Not And (NAND) returns true when at least one input is false.
Nor (NOR) returns true when both inputs are false.
Equal (XNOR) returns true when both inputs are equal.
Not Equal (XOR) returns true when both inputs are different.
Imply (IMPLY) returns true unless the first input is true and the second is false.
Subtract (NIMPLY) returns true when the first input is true and the second is false.

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 19842
Build 19842: arc lint + arc unit

Event Timeline

Hallam Roberts (MysteryPancake) requested review of this revision.Jan 8 2022, 3:19 PM

Hallam Roberts (MysteryPancake) created this revision.

Harbormaster completed remote builds in B19842: Diff 46761.Jan 8 2022, 3:19 PM

Hallam Roberts (MysteryPancake) retitled this revision from Boolean Math: added NAND, NOR, XOR, XNOR, IMPLY, NIMPLY to Geometry Nodes: Added NAND, NOR, XOR, XNOR, IMPLY, NIMPLY to Boolean Math.Jan 8 2022, 3:32 PM

Hallam Roberts (MysteryPancake) edited the summary of this revision. (Show Details)

Hallam Roberts (MysteryPancake) added a project: Geometry Nodes.

Hallam Roberts (MysteryPancake) added a project: Nodes.Jan 8 2022, 3:53 PM

paul szajner (szap) added a subscriber: paul szajner (szap).Jan 8 2022, 4:03 PM

Hallam Roberts (MysteryPancake) retitled this revision from Geometry Nodes: Added NAND, NOR, XOR, XNOR, IMPLY, NIMPLY to Boolean Math to Geometry Nodes: Add NAND, NOR, XOR, XNOR, IMPLY, NIMPLY to Boolean Math.Jan 8 2022, 5:39 PM

Hallam Roberts (MysteryPancake) edited the summary of this revision. (Show Details)

Hallam Roberts (MysteryPancake) added a reviewer: Geometry Nodes.Jan 9 2022, 1:52 AM

Hallam Roberts (MysteryPancake) edited the summary of this revision. (Show Details)Jan 9 2022, 2:59 AM

Hallam Roberts (MysteryPancake) edited the summary of this revision. (Show Details)Jan 9 2022, 4:28 AM

As someone who hasn't encountered the "implies" and "not implies" operations in situations like this before, I'm not sure they would make it easier for me to understand a node tree. The others I think would be great additions! Maybe others have more opinions about the last two.

In D13774#364880, @Hans Goudey (HooglyBoogly) wrote:

As someone who hasn't encountered the "implies" and "not implies" operations in situations like this before, I'm not sure they would make it easier for me to understand a node tree. The others I think would be great additions! Maybe others have more opinions about the last two.

"Implies" and "Not Implies" can be useful in situations when you want to respect a boolean only under certain circumstances, much like an enable/disable toggle.

E.G.
Use boolean B when boolean A applies, otherwise return true = Implies
Use boolean B when boolean A applies, otherwise return false = And

For example, if "Set Position" was an action you want to occur unless explicitly stated otherwise:

It is used in various games, for example:
https://minecraft.fandom.com/wiki/Redstone_circuits/Logic#IMPLY_gate
https://nomanssky.fandom.com/wiki/Combinational_Circuits#IMPLY_Gate

"Implies" and "Not Implies" are also the only gates that depend on the order of the inputs.
I was thinking of adding "Converse" and "Not Converse" operators, but you can get the same outcome by swapping the inputs.

Charlie Jolly (charlie) awarded a token.Jan 9 2022, 7:54 PM

Thank you, I think it would be nice to have mote boolean logic in the node!

Some remarks:

I think the naming should be consistent with itself here: Exclusive Nor -> Exclusive Not Or

I'm not sure about the Implies gates. I feel like this should rather be done with the Switch node. That one seems more intuitive and allows to define a fallback as well. But I don't really have a strong opinion against including them here.

Changed Not Or to Nor for consistency

Harbormaster completed remote builds in B19860: Diff 46804.Jan 10 2022, 2:36 PM

Change Not Or to Nor

Harbormaster completed remote builds in B19861: Diff 46805.Jan 10 2022, 2:47 PM

In D13774#365117, @Simon Thommes (simonthommes) wrote:

Thank you, I think it would be nice to have mote boolean logic in the node!

Some remarks:

I think the naming should be consistent with itself here: Exclusive Nor -> Exclusive Not Or

I'm not sure about the Implies gates. I feel like this should rather be done with the Switch node. That one seems more intuitive and allows to define a fallback as well. But I don't really have a strong opinion against including them here.

I agree, the naming should be more consistent. Changed from "Not Or" to "Nor" to keep everything short.

It can be done with a Switch, though it appears more complex:

The main reason for its inclusion is for a complete set of logic gates. There are other uses for the gate which apply heavily in math, especially in conditional proofs.

Hallam Roberts (MysteryPancake) edited the summary of this revision. (Show Details)Jan 10 2022, 3:07 PM

Hallam Roberts (MysteryPancake) edited the summary of this revision. (Show Details)Jan 10 2022, 3:10 PM

I'm fine with adding the implies operations, I don't really think there's a strong reason not to, and it's not like this menu can grow much more in the future.

The patch looks good to me.

Jacques Lucke (JacquesLucke) accepted this revision.Jan 13 2022, 12:59 PM

This revision is now accepted and ready to land.Jan 13 2022, 12:59 PM

Hallam Roberts (MysteryPancake) closed this revision.Jan 13 2022, 2:06 PM

Sorry, closed by accident (not sure how to commit)

This revision is now accepted and ready to land.Jan 13 2022, 2:09 PM

I'll commit it.

@Hallam Roberts (MysteryPancake) Would you like this to be committed with your real name? If yes, please let me know your real name.

Also see our guidelines here: https://wiki.blender.org/wiki/Style_Guide/Commit_Messages#Author_.2F_Committer

In D13774#366666, @Jacques Lucke (JacquesLucke) wrote:

@Hallam Roberts (MysteryPancake) Would you like this to be committed with your real name? If yes, please let me know your real name.

Also see our guidelines here: https://wiki.blender.org/wiki/Style_Guide/Commit_Messages#Author_.2F_Committer

Thank you, I would like to not use my real name if possible.

Vyacheslav (hitrpr) awarded a token.Jan 14 2022, 12:42 AM

will «boolean equal» be implemented, or integer equal works as fast as boolean already?

In D13774#366856, @Vyacheslav (hitrpr) wrote:

will «boolean equal» be implemented, or integer equal works as fast as boolean already?

Exclusive Nor is boolean equal (true when both are equivalent).

Maybe Exclusive Or should be renamed to "Not Equal" and Exclusive Nor to "Equal" ?

Hallam Roberts (MysteryPancake) edited the summary of this revision. (Show Details)Jan 14 2022, 1:36 AM

Exclusive Nor is boolean equal (returns true when both are equivalent)

Oh, true!

As I think, names «equal» or «not equal» have more clarity and simplicity.
Just as one operation instead three (not + or + if equal), and tooltip can remind, that they are xor and xnor

Hallam Roberts (MysteryPancake) edited the summary of this revision. (Show Details)Jan 14 2022, 2:19 AM

Hallam Roberts (MysteryPancake) edited the summary of this revision. (Show Details)Jan 14 2022, 2:24 AM

Rename XOR to Not Equal, XNOR to Equal for clarity

Harbormaster completed remote builds in B19980: Diff 47052.Jan 14 2022, 2:34 AM

Updated naming as suggested by Vyacheslav.

"Exclusive Or" and "Exclusive Nor" are technical terms which don't clearly state what they do.
Nobody will use them if it's not clear what they do (I also forget what they do quite often)

"Not Equal" and "Equal" are immediately clear, and much shorter terms.
This goes with the idea of making the node tree more understandable, as mentioned by Hans.

It also improves consistency between the "Compare" node and "Boolean Math".

Operations are still named XOR and XNOR in the codebase, will change if requested.

Hallam Roberts (MysteryPancake) edited the summary of this revision. (Show Details)Jan 14 2022, 3:00 AM

Change "Implies" to noun form "Imply", to match "Equal" as opposed to "Equals"

Harbormaster completed remote builds in B19984: Diff 47056.Jan 14 2022, 3:54 AM

Hallam Roberts (MysteryPancake) edited the summary of this revision. (Show Details)Jan 14 2022, 3:56 AM

Iliya Katueshenock (Moder) added a subscriber: Iliya Katueshenock (Moder).Jan 21 2022, 11:36 PM

I'm wondering whether something like subtract could make sense. That could be used to subtract one selection from another.

I realize that this is the same as "Not Imply", but that name is confusing in this context. Not sure if there is a better name than "subtract" here. An alternative could be to have a separate Combine Selections node, that uses more obvious names (e.g. union)

Adding @Hans Goudey (HooglyBoogly) as reviewer again, because the naming has changed in the patch.

This revision now requires review to proceed.Jan 23 2022, 4:48 PM

Rename Not Imply to Subtract for clarity

Harbormaster completed remote builds in B20119: Diff 47360.Jan 23 2022, 6:54 PM

Hallam Roberts (MysteryPancake) edited the summary of this revision. (Show Details)Jan 23 2022, 7:14 PM

Hallam Roberts (MysteryPancake) edited the summary of this revision. (Show Details)Jan 24 2022, 3:30 AM

I'm fine with the naming here. And the descriptions are great, so this looks good to me.

This revision is now accepted and ready to land.Jan 24 2022, 7:10 AM

Paul Kotelevets (1D_Inc) awarded a token.Jan 24 2022, 10:55 AM

Closed by commit rB14f6afb09003: Geometry Nodes: Expand the Boolean Math node (authored by Hallam Roberts (MysteryPancake), committed by Hans Goudey (HooglyBoogly)). · Explain WhyJan 25 2022, 4:10 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB14f6afb09003: Geometry Nodes: Expand the Boolean Math node.

Little note.
I checked table of imply.
And it is literally «Less or equal»
Probably name should be changed to more familiar variant. And keep «Implification» in tooltip for math-ppl ofc.

In D13774#371657, @Vyacheslav (hitrpr) wrote:

Little note.
I checked table of imply.
And it is literally «Less or equal»
Probably name should be changed to more familiar variant. And keep «Implification» in tooltip for math-ppl ofc.

I was thinking this too, though maybe it would be better to add boolean support to the Compare node to allow other comparisons like this (Less, Greater, Greater or Equal).

"Not Imply" is also equivalent to "Greater", though I like the name "Subtract"

Perhaps Equal/Not Equal/Imply/Subtract should be moved to the Compare node.

Could continue discussion on https://developer.blender.org/D13978

Geometry Nodes: Add NAND, NOR, XOR, XNOR, IMPLY, NIMPLY to Boolean Math
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 46761

source/blender/makesdna/DNA_node_types.h

source/blender/makesrna/intern/rna_nodetree.c

source/blender/nodes/function/nodes/node_fn_boolean_math.cc

Geometry Nodes: Add NAND, NOR, XOR, XNOR, IMPLY, NIMPLY to Boolean MathClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46761

source/blender/makesdna/DNA_node_types.h

source/blender/makesrna/intern/rna_nodetree.c

source/blender/nodes/function/nodes/node_fn_boolean_math.cc

Geometry Nodes: Add NAND, NOR, XOR, XNOR, IMPLY, NIMPLY to Boolean Math
ClosedPublic
Actions

Revision Contents
Changeset List