Page MenuHome
Differential D13780

Fix T94085: Crash with empty stroke list
AbandonedPublic
Actions

Authored by Pratik Borhade (PratikPB2123) on Jan 9 2022, 12:54 PM.

Details

Reviewers
None
Maniphest Tasks
T94085: Calling bpy.ops.curve.draw with an empty stroke list causes a segfault
Summary

Fix T94085.
Exit the code early if stroke list is empty
Otherwise exception will be thrown for writing at unallocated memory

Diff Detail

Repository
rB Blender

Event Timeline

Pratik Borhade (PratikPB2123) requested review of this revision.Jan 9 2022, 12:54 PM
Pratik Borhade (PratikPB2123) created this revision.
Pratik Borhade (PratikPB2123) added a subscriber: Campbell Barton (campbellbarton).

Hi @Campbell Barton (campbellbarton) , can you review this patch?

Campbell Barton (campbellbarton) abandoned this revision.Feb 15 2022, 9:54 AM

Thanks for the patch, I ended up committing an alternative fix.

  • Exit in curve_draw_init since it allocates memory which needs to be freed.
  • I don't think RNA_struct_property_is_set is correct as a property could be set but still to an empty list.
Pratik Borhade (PratikPB2123) added a comment.Feb 15 2022, 12:19 PM

No problem. Thanks for reviewing :)

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
curve/
4 lines

Diff 46776

View Options

source/blender/editors/curve/editcurve_paint.c

Loading...