Fix error when keyframing with Custom Properties
ClosedPublic
Actions

Authored by Demeter Dzadik (Mets) on Jan 10 2022, 12:34 PM.

Details

Reviewers

Sybren A. Stüvel (sybren)

Commits

rB3ec88ae21df9: Fix error when keyframing with Custom Properties

Summary

It seems that in the past, the data.path_resolve() would raise a ValueError when the custom property's value was None. This no longer seems to be the case, it actually returns None now, so replaced the try/except with a None check.

Test file:

D13787.blend691 KBDownload

(Will say successfully inserted 10 keyframes but throw error in console when trying to Insert Keyframe)

Diff Detail

Repository: rB Blender

Event Timeline

Demeter Dzadik (Mets) requested review of this revision.Jan 10 2022, 12:34 PM

Demeter Dzadik (Mets) created this revision.

Harbormaster completed remote builds in B19857: Diff 46800.Jan 10 2022, 12:34 PM

Demeter Dzadik (Mets) edited the summary of this revision. (Show Details)Jan 10 2022, 12:39 PM

The change: rBf9ccd26b037d. It resolves the issue that a None value caused a ValueError. However, I can't find anything about other reasons to raise that exception. This code is still in place:

PyErr_Format(PyExc_ValueError,
             "%.200s.path_resolve(\"%.200s\") could not be resolved",
             RNA_struct_identifier(self->ptr.type),
             path);