Page MenuHome
Differential D13790

Fix T93727: Tiled render error in Cycles after changing temp directory
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Jan 10 2022, 4:08 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rC4081365cf723: Fix T93727: Tiled render error in Cycles after changing temp directory
rB292c2cefe30b: Fix T93727: Tiled render error in Cycles after changing temp directory
Summary

Consider temporary directory to be variant part of session configuration
which gets communicated to the tile manager on render reset.

This allows to be able to render with one temp directory, change the
directory, render again and have proper render result even with enabled
persistent data.

For the ease of access to the temp directory expose it via the render
engine API.

Diff Detail

Repository
rB Blender
Branch
fix_cycles_tempdir (branched from master)
Build Status
Buildable 19863
Build 19863: arc lint + arc unit

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Jan 10 2022, 4:08 PM
Sergey Sharybin (sergey) created this revision.
Harbormaster completed remote builds in B19863: Diff 46807.Jan 10 2022, 4:08 PM
Brecht Van Lommel (brecht) requested changes to this revision.Jan 10 2022, 4:22 PM

I guess this still fails when changing the temporary directory in the middle of rendering, as Blender will delete the old directory.

We could delay deleting non-empty temp directories until Blender closes. Not sure if that's worth it, or would be considered something to fix at all.

source/blender/makesrna/intern/rna_render.c
874

I don't think this should be abbreviated, we have temporary_directory in the preferences so I would use that.

875

I don't think we have to mention (read-only), we don't have it for other properties like resolution either.

This revision now requires changes to proceed.Jan 10 2022, 4:22 PM
Sergey Sharybin (sergey) updated this revision to Diff 46811.Jan 10 2022, 4:38 PM

Made naming and description more consistent with RNA

P.S. Previous name and docstring was copied from bpy.app.tempdir ;)

Harbormaster completed remote builds in B19866: Diff 46811.Jan 10 2022, 4:38 PM
Brecht Van Lommel (brecht) accepted this revision.Jan 10 2022, 4:41 PM
This revision is now accepted and ready to land.Jan 10 2022, 4:41 PM
Closed by commit rB292c2cefe30b: Fix T93727: Tiled render error in Cycles after changing temp directory (authored by Sergey Sharybin (sergey)). · Explain WhyJan 10 2022, 5:05 PM
This revision was automatically updated to reflect the committed changes.
Sergey Sharybin (sergey) added a commit: rB292c2cefe30b: Fix T93727: Tiled render error in Cycles after changing temp directory.
Brecht Van Lommel (brecht) added a commit: rC4081365cf723: Fix T93727: Tiled render error in Cycles after changing temp directory.Jan 27 2022, 11:38 PM

Revision Contents
Changeset List

PathSize
intern/
cycles/
blender/
addon/
3 lines
10 lines
8 lines
session/
3 lines
5 lines
4 lines
9 lines
util/
3 lines
13 lines
source/
blender/
makesrna/
intern/
17 lines

Diff 46807

View Options

intern/cycles/blender/addon/engine.py

Loading...
View Options

intern/cycles/blender/python.cpp

Loading...
View Options

intern/cycles/blender/sync.cpp

Loading...
View Options

intern/cycles/session/session.h

Loading...
View Options

intern/cycles/session/session.cpp

Loading...
View Options

intern/cycles/session/tile.h

Loading...
View Options

intern/cycles/session/tile.cpp

Loading...
View Options

intern/cycles/util/path.h

Loading...
View Options

intern/cycles/util/path.cpp

Loading...
View Options

source/blender/makesrna/intern/rna_render.c

Loading...