With this change, compilation saw a 2.4x improvement.
This can be combined with unity build to give an overall 4x improvement
Depends on D13797
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- compositor-pch (branched from master)
- Build Status
Buildable 19910 Build 19910: arc lint + arc unit
Event Timeline
Comment Actions
I am fine with the change, but I should not sign off on this ticket. CMake isn't my expertise. So will leave that for the other reviewers.
Personally I guess that the system libraries and the intern headers would be good to add there by default. Not really sure why some operations
would make a difference.
Comment Actions
Yeah, I tried to include any system includes along with any includes that are used often.
These operations are generic and used often by other operations.
| source/blender/compositor/COM_precomp.h | ||
|---|---|---|
| 2 | How's the unity build related to precompiled headers? | |
| source/blender/compositor/COM_precomp.h | ||
|---|---|---|
| 2 | This was added in the other PCH file for freestyle in rBf0ff593d9784a78ef807608d54617a62986522d0 I am not pressed on keeping the comment, just added to keep convention. | |
Comment Actions
As you pointed out on chat, there's maybe a another 500ms to gain by adding COM_Debug.h , but all the really expensive stuff has been taken care of already, up to you if you want to include it, accepted regardless.