Add workaround for broken interface query functions on Intel HD Graphics 4400 and 4600
ClosedPublic
Actions

Authored by Jake (Welp) on Jan 12 2022, 1:03 AM.

Details

Reviewers

Clément Foucault (fclem)
Jeroen Bakker (jbakker)

Maniphest Tasks

T93680: Blender 3.0 is crashing when creating hair particle system (Windows, Intel)

Commits

rB263f862ba567: Add workaround for broken interface query functions on Intel HD Graphics 4400…

Summary

Fixes T93680

For current drivers of Intel HD Graphics 4400 and 4600, various Program Introspection functions appear broken and return incorrect values, causing crashes in the current handling of SSBOs. Disable use of this feature on those devices. Add checks to features that use SSBOs (Hair and Subdivision Modifier).

Diff Detail

Repository: rB Blender

Event Timeline

Jake (Welp) requested review of this revision.Jan 12 2022, 1:03 AM

Jake (Welp) created this revision.

Harbormaster completed remote builds in B19919: Diff 46936.Jan 12 2022, 1:03 AM

Thanks! Note that this workaround should be fixed after D13360 is merged to master since we won't rely on the driver shader introspection anymore.

This revision is now accepted and ready to land.Jan 12 2022, 9:39 AM

Pratik Borhade (PratikPB2123) mentioned this in T93680: Blender 3.0 is crashing when creating hair particle system (Windows, Intel).Jan 12 2022, 12:30 PM

Got it, I'll keep an eye on it.

Pratik Borhade (PratikPB2123) awarded a token.Jan 13 2022, 10:03 AM

Shane Ashby (shaneashby) added a subscriber: Shane Ashby (shaneashby).Jan 19 2022, 6:27 AM

In D13806#366018, @Clément Foucault (fclem) wrote:

Thanks! Note that this workaround should be fixed after D13360 is merged to master since we won't rely on the driver shader introspection anymore.

Looks like it's still crashing in the same place on the current master.

In D13806#368616, @Jake (Welp) wrote:

In D13806#366018, @Clément Foucault (fclem) wrote:

Thanks! Note that this workaround should be fixed after D13360 is merged to master since we won't rely on the driver shader introspection anymore.

Looks like it's still crashing in the same place on the current master.

Well the issue is that the initial patch only does the shader create info (which bypass introspection) for the "builtin" shaders. Other shaders should follow afterwards. But knowing this issue, I will push for the compute shader to be done first.

Jeroen Bakker (jbakker) accepted this revision.Jan 21 2022, 12:38 PM

Closed by commit rB263f862ba567: Add workaround for broken interface query functions on Intel HD Graphics 4400… (authored by Clément Foucault (fclem)). · Explain WhyJan 24 2022, 6:49 PM

This revision was automatically updated to reflect the committed changes.

Clément Foucault (fclem) added a commit: rB263f862ba567: Add workaround for broken interface query functions on Intel HD Graphics 4400….