Differential D13811

WIP: Move evaluated mesh in edit mode from editmesh to mesh->runtime
AbandonedPublic
Actions

Authored by Sergey Sharybin (sergey) on Jan 12 2022, 11:46 AM.

Tags

None

Subscribers

None

Details

Reviewers: None

Summary

Avoids material ID pointers shared across different dependency graphs
causing ownership issues.

The downside of the current implementation is that when multiple
objects are sharing the same mesh they don't show same edit mesh and
cage while editing.

P.S. The cage mesh bounding box should in theory also be moved but
currently it is not causing issues and there is no clarity of where
we will move from here, so didn't want to spend time on it yet.

Diff Detail

Repository

Branch

fix_T93855_experiment_mesh (branched from master)

Build Status

Buildable 19931
Build 19931: arc lint + arc unit

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Jan 12 2022, 11:46 AM

Sergey Sharybin (sergey) created this revision.

Harbormaster completed remote builds in B19931: Diff 46968.Jan 12 2022, 11:46 AM

Since it was more of an experiment and some PoC code to simplify discussion abandoning this version.
The evaluated result should be on Object level as it is affected by object's modifiers.

Sergey Sharybin (sergey) mentioned this in D13808: Fix T94230: Crash rendering with EEVEE in mesh edit-mode.Jan 13 2022, 10:16 AM

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

6 lines

intern/

28 lines

26 lines

4 lines

mesh_convert.cc

4 lines

6 lines

2 lines

object_dupli.cc

3 lines

draw/

engines/

overlay/

overlay_edit_mesh.c

3 lines

overlay_wireframe.c

8 lines

select/

select_draw_utils.c

2 lines

intern/

draw_cache_extract.h

4 lines

draw_cache_extract_mesh_render_data.c

6 lines

draw_cache_impl_mesh.c

12 lines

draw_cache_impl_subdivision.cc

2 lines

5 lines

editors/

mesh/

editmesh_utils.c

5 lines

transform/

transform_snap_object.c

25 lines

util/

ed_transverts.c

7 lines

makesdna/

DNA_mesh_types.h

2 lines

modifiers/

intern/

3 lines

Diff 46968

source/blender/blenkernel/BKE_editmesh.h

Loading...

source/blender/blenkernel/intern/DerivedMesh.cc

Loading...

source/blender/blenkernel/intern/editmesh.c

Loading...

source/blender/blenkernel/intern/material.c

Loading...

source/blender/blenkernel/intern/mesh_convert.cc

Loading...

source/blender/blenkernel/intern/modifier.c

Loading...

source/blender/blenkernel/intern/object.cc

Loading...

source/blender/blenkernel/intern/object_dupli.cc

Loading...

source/blender/draw/engines/overlay/overlay_edit_mesh.c

Loading...

source/blender/draw/engines/overlay/overlay_wireframe.c

Loading...

source/blender/draw/engines/select/select_draw_utils.c

Loading...

source/blender/draw/intern/draw_cache_extract.h

Loading...

source/blender/draw/intern/draw_cache_extract_mesh_render_data.c

Loading...

source/blender/draw/intern/draw_cache_impl_mesh.c

Loading...

source/blender/draw/intern/draw_cache_impl_subdivision.cc

Loading...

source/blender/draw/intern/draw_manager.c

Loading...

source/blender/editors/mesh/editmesh_utils.c

Loading...

source/blender/editors/transform/transform_snap_object.c

Loading...

source/blender/editors/util/ed_transverts.c

Loading...

source/blender/makesdna/DNA_mesh_types.h

Loading...

source/blender/modifiers/intern/MOD_subsurf.c

Loading...