Page MenuHome

Core: Library Remap test cases.
ClosedPublic

Authored by Jeroen Bakker (jbakker) on Jan 12 2022, 3:54 PM.

Details

Summary

For an upcoming refactoring of library remapping we want to be able to test if the logic won't change.
It also increased my experience inside the remapping codebase and find out what exactly needed to
be refactored.

This patch adds test cases for the core functionality of foreach_libblock_remap_callback. The test cases
don't cover of all the branches. Also pre-, post-processing, referencing and proxies are not tested.

Diff Detail

Repository
rB Blender

Event Timeline

  • Added test cases for never null.
source/blender/blenkernel/intern/lib_remap_test.cc
17

2022

Jeroen Bakker (jbakker) marked an inline comment as not done.Jan 14 2022, 2:38 PM
  • Updated license header.
Jeroen Bakker (jbakker) requested review of this revision.Jan 14 2022, 3:11 PM
Jeroen Bakker (jbakker) retitled this revision from Lib remap test cases. to Core: Library Remap test cases..

Besides notes, lgtm...

source/blender/blenkernel/intern/lib_remap_test.cc
88

Is there a reason why this one (and next one) are virtual instead of override?

99

Same question as above

This revision is now accepted and ready to land.Jan 17 2022, 11:15 AM
Jeroen Bakker (jbakker) marked 2 inline comments as done.
  • Fixed missing override keyword.
This revision was automatically updated to reflect the committed changes.