Fix T94827: Group Input/Output cannot connect to custom sockets
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jan 12 2022, 4:51 PM.

Details

Reviewers

Jacques Lucke (JacquesLucke)
Jeroen Bakker (jbakker)

Maniphest Tasks

T94827: Regression: Group Input/Output cannot connect to some custom sockets

Commits

rB688713db24b1: Fix T94827: Group Input/Output cannot connect to custom sockets
rB85df7036f76b: Fix T94827: Group Input/Output cannot connect to custom sockets

Summary

Caused by rBa5c59fb90ef9.

Since Group Input and Output sockets happen to be of type SOCK_CUSTOM
[and since rBa5c59fb90ef9 custom py defined sockets are too :)] a check
introduced in rB513066e8ad6f that prevents connections for SOCK_CUSTOM
triggered.

Now refine the check, so it specifically looks for NODE_GROUP_INPUT /
NODE_GROUP_OUTPUT, too (this keeps the intention intact to not connect
group inputs to group outputs and vice versa, but allows custom py
defined sockets to connect again).

Diff Detail

Repository

rB Blender

Branch

T94827 (branched from master)

Build Status

Buildable 19994
Build 19994: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Jan 12 2022, 4:51 PM

Philipp Oeser (lichtwerk) created this revision.

Philipp Oeser (lichtwerk) added a task: T94827: Regression: Group Input/Output cannot connect to some custom sockets.

This fixes it for me. Just built the patch and it's working again. Thank you for the fix, and the
speed!

Joseph Brandenburg (TheAngerSpecialist) awarded a token.Jan 12 2022, 5:13 PM

Can we have a static bool is_group_extension_socket(const bNode *node, const bNodeSocket *socket) utility method? That would make it more obvious what is being tested here imo.