Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T91379: Add operators to convert generic attributes into task specific data (UVLayers, etc)

Commits

rBf6888b530ac8: Attributes: add operator to convert generic attributes to other types

Summary

The main goal here is to provide a workaround for until all exporters etc. support generic attributes.

The operator supports converting attributes to uv maps, vertex groups and other generic attributes.

Diff Detail

Repository

rB Blender

Branch

attribute-conversion-operators (branched from master)

Build Status

Buildable 20091
Build 20091: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Jan 14 2022, 5:13 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B20005: Diff 47084.Jan 14 2022, 5:13 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Jan 14 2022, 5:17 PM

Merge branch 'master' into attribute-conversion-operators
rename operator
add menu
implement different modes

Harbormaster completed remote builds in B20091: Diff 47274.Jan 20 2022, 4:37 PM

Jacques Lucke (JacquesLucke) retitled this revision from Attributes: Add operator to convert attributes to legacy attributes. (WIP) to Attributes: Add operator to convert generic attributes to other types.Jan 20 2022, 4:40 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)

support converting to vertex color and add warning

Harbormaster completed remote builds in B20092: Diff 47277.Jan 20 2022, 5:00 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Jan 20 2022, 5:02 PM

Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).

The code looks very straightforward, and I like the design you chose for the conversion options. This looks good to me.

The commit message should have bit more detail than the patch description, and should mention that only meshes are supported currently, but it would be relatively easy to add support for point clouds and hair/curves in the future.

source/blender/editors/geometry/geometry_attributes.cc
52–58	Or this file could be moved to `blender::ed::geometry` instead, either way.
351	These "identifiers" "api callbacks" and "flags" comments are useless IMO, no need to copy them around.
367	Didn't test it, but what's your opinion on using `int(ConvertAttributeMode::UVMap)` instead of the full `static_cast`?
380	A description here is more difficult, but this is a bit too close to the `data_type` description IMO. Maybe this is a bit more clear? `Convert to a different generic attribute type or a more specific data type` A bit hard to think of a great description for this one. If nothing seems helpful, having no description at all seems fine.
387	Avoid using the name of the property in its description wherever possible. Here, maybe this would be better: `Which geometry element to move the attribute to`