Paths

Table of Contentst

Line Art feature update: Option to keep contour when using face mark filtering
ClosedPublic
Actions

Authored by YimingWu (NicksBest) on Jan 17 2022, 1:24 AM.

Details

Reviewers

Antonio Vazquez (antoniov)
Aleš Jelovčan (frogstomp)

Group Reviewers

Grease Pencil

Maniphest Tasks

T87739: Line Art further improvement list

Commits

rBdde997086ce2: LineArt: Option to keep contour when using face mark filtering.

Summary

When enabled, it will keep contour around the object instead of hide them by rule of face mark, so the object can always have full contour while filtering out some of the feature lines inside certain regions.

From left to right: mesh setup, face mark filtering without "keep contour", with "keep contour"

Diff Detail

Repository: rB Blender

Event Timeline

YimingWu (NicksBest) requested review of this revision.Jan 17 2022, 1:24 AM

YimingWu (NicksBest) created this revision.

YimingWu (NicksBest) added a task: T87739: Line Art further improvement list.

YimingWu (NicksBest) edited the summary of this revision. (Show Details)Jan 17 2022, 1:36 AM

There are several white space changes, probably caused by clang format? hummm...

YimingWu (NicksBest) added a reviewer: Grease Pencil.Jan 17 2022, 1:39 AM

Just a few comments about format. The code LGTM, but we need some testing.

@Aleš Jelovčan (frogstomp) could you test the patch?

source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c
1890	Not sure if clang is moving `*/` to next line.
2447	`* files. */`
source/blender/makesdna/DNA_gpencil_modifier_defaults.h
318	extra blank line here?

Accept the patch pending of test. Remember to change the clang issues.

This revision is now accepted and ready to land.Jan 17 2022, 10:31 AM

Antonio Vazquez (antoniov) added a reviewer: Aleš Jelovčan (frogstomp).Jan 17 2022, 10:36 AM

Closed by commit rBdde997086ce2: LineArt: Option to keep contour when using face mark filtering. (authored by YimingWu (NicksBest)). · Explain WhyJan 22 2022, 10:09 AM

This revision was automatically updated to reflect the committed changes.

YimingWu (NicksBest) added a commit: rBdde997086ce2: LineArt: Option to keep contour when using face mark filtering..

Revision Contents
Changeset List

Path

Size

source/

blender/

gpencil_modifiers/

intern/

MOD_gpencillineart.c

1 line

lineart/

MOD_lineart.h

1 line

lineart_cpu.c

40 lines

makesdna/

DNA_gpencil_modifier_defaults.h

3 lines

DNA_lineart_types.h

1 line

makesrna/

intern/

rna_gpencil_modifier.c

6 lines

Diff 47114

View Options

source/blender/gpencil_modifiers/intern/MOD_gpencillineart.c

View Options

source/blender/gpencil_modifiers/intern/lineart/MOD_lineart.h

View Options

source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c

View Options

source/blender/makesdna/DNA_gpencil_modifier_defaults.h

View Options

source/blender/makesdna/DNA_lineart_types.h

View Options

source/blender/makesrna/intern/rna_gpencil_modifier.c

Line Art feature update: Option to keep contour when using face mark filteringClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47114

source/blender/gpencil_modifiers/intern/MOD_gpencillineart.c

source/blender/gpencil_modifiers/intern/lineart/MOD_lineart.h

source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c

source/blender/makesdna/DNA_gpencil_modifier_defaults.h

source/blender/makesdna/DNA_lineart_types.h

source/blender/makesrna/intern/rna_gpencil_modifier.c

Line Art feature update: Option to keep contour when using face mark filtering
ClosedPublic
Actions

Revision Contents
Changeset List