Page MenuHome

Cleanup: VSE animation handling
ClosedPublic

Authored by Richard Antalik (ISS) on Jan 17 2022, 1:26 PM.

Details

Summary
  • Move functions that handle animation to own file - animation.c
  • Refactor SEQ_offset_animdata and SEQ_free_animdata functions
  • Add function SEQ_fcurves_by_strip_name_get to provide more granular and explicit way for operators to handle animation
  • Remove function SEQ_dupe_animdata, do curve duplication explicitly in operator code, which makes more sense to do. Further this function was also used for renaming strips which makes no sense.
  • Refactor usage of function SEQ_free_animdata and remove XXX comment. Now this functiuon is no longer called when Sequence data is freed implicitly, it is done explicitly in high level function SEQ_edit_remove_flagged_sequences

Diff Detail

Repository
rB Blender
Branch
animation_cleanup (branched from master)
Build Status
Buildable 20033
Build 20033: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Jan 17 2022, 1:26 PM
Richard Antalik (ISS) created this revision.
  • Fix paste comment which was based on future work

From quick look seems fine. If there are no functional changes then go ahead :)

This revision is now accepted and ready to land.Jan 17 2022, 3:42 PM
This revision was automatically updated to reflect the committed changes.